Repository navigation
Conversation
Summary (Non-blocking)
Notes
|
This was referenced Sep 19, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Treats positive and negative infinity as malformed integer limits instead of allowing
int()to raiseOverflowError. This preserves the documented never-raises behavior when PyYAML parses.infor-.infintool_outputor hook spill settings.Related Issue
N/A — found during source audit; no matching issue or PR.
Type of Change
Changes Made
tools/tool_output_limits.py: fall back to the configured default onOverflowError.tests/tools/test_tool_output_limits.py: cover positive and negative infinity for all three output limits.How to Test
Parse this configuration with PyYAML and return it from
load_config():Call
get_tool_output_limits().Verify
max_bytesis50000rather than anOverflowError.The focused test passes all 17 tests:
Ruff and the Windows-footgun check pass for both changed files. The full suite was also attempted with
.[all,dev]; 26 unrelated integration files still fail because optional providers and machine-local state are not hermetic here, so the full-suite checkbox remains unchecked.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
N/A — configuration coercion is covered by regression tests.