test(kanban): isolate HERMES_KANBAN_BOARD writes in pin-env tests

teknium1 · teknium1 · commit f8a6db68ca7a · 2026-05-05T04:37:47.000-07:00
The helper under test writes to os.environ directly, bypassing
monkeypatch tracking. Without an explicit snapshot/restore fixture,
the mutation leaks into subsequent tests and breaks TestSharedBoardPaths
(kanban path resolution reads HERMES_KANBAN_BOARD and routes through
boards/&lt;leaked-slug&gt;/ instead of the test's own HERMES_HOME).

Add an autouse fixture that snapshots the env var before the test and
restores (or pops) it after, regardless of what the helper did.
diff --git a/tests/hermes_cli/test_pin_kanban_board_env.py b/tests/hermes_cli/test_pin_kanban_board_env.py
@@ -8,10 +8,32 @@
 shell calls to a different DB.
 """
 import importlib
+import os
+
+import pytest
+
+
+@pytest.fixture(autouse=True)
+def _isolate_kanban_board_env():
+    """Snapshot `HERMES_KANBAN_BOARD` and restore it after the test.
+
+    `_pin_kanban_board_env()` writes to ``os.environ`` directly, bypassing
+    any ``monkeypatch.setenv`` tracking. Without this fixture the mutation
+    leaks into subsequent tests and breaks anything that resolves a kanban
+    path from the env (e.g. ``TestSharedBoardPaths`` in test_kanban_db.py).
+    """
+    prev = os.environ.get("HERMES_KANBAN_BOARD")
+    os.environ.pop("HERMES_KANBAN_BOARD", None)
+    try:
+        yield
+    finally:
+        if prev is None:
+            os.environ.pop("HERMES_KANBAN_BOARD", None)
+        else:
+            os.environ["HERMES_KANBAN_BOARD"] = prev
 
 
 def test_pin_writes_resolved_board_when_env_unset(monkeypatch):
-    monkeypatch.delenv("HERMES_KANBAN_BOARD", raising=False)
     main_mod = importlib.import_module("hermes_cli.main")
 
     import hermes_cli.kanban_db as kdb
@@ -39,7 +61,6 @@ def _explode():
 
 
 def test_pin_swallows_resolution_failures(monkeypatch):
-    monkeypatch.delenv("HERMES_KANBAN_BOARD", raising=False)
     main_mod = importlib.import_module("hermes_cli.main")
 
     import hermes_cli.kanban_db as kdb
