Support specifying both PHP and JS code in code blocks#5
Closed
nylen wants to merge 4 commits intoNordth:masterfrom
Closed
Support specifying both PHP and JS code in code blocks#5nylen wants to merge 4 commits intoNordth:masterfrom
nylen wants to merge 4 commits intoNordth:masterfrom
Conversation
4 tasks
Author
|
@Nordth I am interested in maintaining this library because we'd like to use it in the WordPress project referenced above. Thoughts on this PR and on subsequent changes we will need? (Currently, add an option to avoid PHP namespaces; see WordPress/gutenberg#1152 for details) |
Author
|
I've proceeded with this work at https://github.com/nylen/phpegjs. |
Owner
|
Thanks for sharing! I will recomend to use your fork, because have no time to maintain this project for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original
php-pegjsrequires specifying all code inside code blocks as PHP. However, for WordPress/gutenberg we want to use the same PEG in both PHP and JS code (see WordPress/gutenberg#1086).Accordingly, this PR adds the capability to specify both PHP and JS code in the same code block, using a syntax that is ignored by normal PEG.js, as follows:
This PR also fixes an instance of
void 0being inserted into the generated PHP code. Elsewhere ingenerate-bytecode-php.jsthis isnullinstead, so the same change has been made here.