Repository navigation
Commit 4b075f3
feat: Add read_from and client_az options to the Redis GLIDE client
The GLIDE client added in feast-dev#6870 always read from the primary, because
the Feast config had no way to pass GLIDE's read strategy through.
Clusters with replicas could not spread online reads across them.
Add two RedisOnlineStoreConfig options that map onto GLIDE's own
settings:
* read_from: primary (default), prefer_replica, az_affinity,
az_affinity_replicas_and_primary or all_nodes, translated to
glide_sync.ReadFrom.
* client_az: the client's availability zone, used by the az_affinity
strategies.
The config is validated at load time so a setting can never be silently
ignored:
* read_from and client_az require client: glide, since redis-py does not
use them.
* A read_from other than primary requires redis_type: redis_cluster. A
standalone GLIDE client sends every batch to the primary, so the
batched HMGET read would ignore the strategy.
* The az_affinity strategies require client_az, which GLIDE also
enforces when building the client config.
Verified against a Valkey 8 cluster with one primary and one replica:
prefer_replica and az_affinity send the batched online_read to the
replica, all_nodes spreads it over both nodes, and the default keeps
reading from the primary.
Fixes feast-dev#7086
Signed-off-by: NopeCharon <[email protected]>1 parent fb5e5d5 commit 4b075f3
3 files changed
Lines changed: 134 additions & 1 deletion
File tree
- docs/reference/online-stores
- sdk/python
- feast/infra/online_stores
- tests/unit/infra/online_store
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
140 | 140 | | |
141 | 141 | | |
142 | 142 | | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
143 | 170 | | |
144 | 171 | | |
145 | 172 | | |
| |||
173 | 200 | | |
174 | 201 | | |
175 | 202 | | |
| 203 | + | |
| 204 | + | |
176 | 205 | | |
177 | 206 | | |
178 | 207 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
| 32 | + | |
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| |||
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
78 | 91 | | |
79 | 92 | | |
80 | 93 | | |
| |||
93 | 106 | | |
94 | 107 | | |
95 | 108 | | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
96 | 119 | | |
97 | 120 | | |
98 | 121 | | |
| |||
111 | 134 | | |
112 | 135 | | |
113 | 136 | | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
114 | 159 | | |
115 | 160 | | |
116 | 161 | | |
| |||
180 | 225 | | |
181 | 226 | | |
182 | 227 | | |
| 228 | + | |
| 229 | + | |
183 | 230 | | |
184 | 231 | | |
185 | 232 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
| |||
885 | 886 | | |
886 | 887 | | |
887 | 888 | | |
| 889 | + | |
| 890 | + | |
888 | 891 | | |
889 | 892 | | |
890 | 893 | | |
| |||
908 | 911 | | |
909 | 912 | | |
910 | 913 | | |
| 914 | + | |
| 915 | + | |
| 916 | + | |
| 917 | + | |
| 918 | + | |
| 919 | + | |
| 920 | + | |
| 921 | + | |
| 922 | + | |
| 923 | + | |
| 924 | + | |
| 925 | + | |
| 926 | + | |
| 927 | + | |
| 928 | + | |
| 929 | + | |
| 930 | + | |
| 931 | + | |
| 932 | + | |
| 933 | + | |
| 934 | + | |
| 935 | + | |
| 936 | + | |
| 937 | + | |
| 938 | + | |
| 939 | + | |
| 940 | + | |
| 941 | + | |
| 942 | + | |
| 943 | + | |
| 944 | + | |
| 945 | + | |
| 946 | + | |
| 947 | + | |
| 948 | + | |
| 949 | + | |
| 950 | + | |
| 951 | + | |
| 952 | + | |
| 953 | + | |
| 954 | + | |
| 955 | + | |
| 956 | + | |
| 957 | + | |
| 958 | + | |
| 959 | + | |
| 960 | + | |
| 961 | + | |
| 962 | + | |
| 963 | + | |
| 964 | + | |
| 965 | + | |
| 966 | + | |
| 967 | + | |
911 | 968 | | |
912 | 969 | | |
913 | 970 | | |
| |||
0 commit comments