Merged
Conversation
🦋 Changeset detectedLatest commit: c89cb91 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kanej
added
no docs needed
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the defensive deep-clone performed in the network manager’s onRequest hook handler chain to eliminate a known performance bottleneck, accepting (for now) that the incoming JSON-RPC request object may be mutated in place.
Changes:
- Removed
deepCloneusage when processingonRequesthook requests. - Updated local variable naming to reflect request flow through request handlers.
v-next/hardhat/src/internal/builtin-plugins/network-manager/hook-handlers/network.ts
Show resolved
Hide resolved
As part of the `onRequest` hook handler to apply the request mutating subhandlers we applied a defesive deepClone, to ensure the passed in request was not mutated. The `deepClone` is a performance bottleneck we have opted to remove. For the moment, we will accept that the passed in request is updated in place. We have a follow up task to alter the subhandlers to transform rather than mutate, see #8090 Resolves #8046
kanej
force-pushed
the
feat/remove-request-deepclone
branch
from
fe23969 to
c89cb91
Compare
ChristopherDedominici
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of the
onRequesthook handler to apply the request mutating sub-handlers we applied a defesive deepClone, to ensure the passed in request was not mutated.The
deepCloneis a performance bottleneck we have opted to remove.For the moment, we will accept that the passed in request is updated in place. We have a follow up task to alter the subhandlers to transform rather than mutate, see #8090
Resolves #8046
Peer bumps reasoning
We are changing the ownership pattern here for requests within the
onRequesthook. However, we have analyzed the downstream plugins and none are affected in the Nomic or community plugin list.