Verbosity (-vvv) improve style#8031
Conversation
|
ChristopherDedominici
changed the title
ChristopherDedominici
force-pushed
the
improve-verbosity-style
branch
from
ef0e0b5 to
1949195
Compare
ChristopherDedominici
force-pushed
the
improve-verbosity-style
branch
from
1949195 to
74df490
Compare
| @@ -0,0 +1,93 @@ | |||
| // SPDX-License-Identifier: MIT | |||
There was a problem hiding this comment.
IGNORE: only used for manual testing - will be removed before merging.
Run pnpm hardhat run scripts/demo-trace-output.ts -vvvv (or -vvvvv) in example-project to see a demo
There was a problem hiding this comment.
Actually, I will keep them, it could be useful for the future
| @@ -0,0 +1,176 @@ | |||
| /** | |||
There was a problem hiding this comment.
IGNORE: only used for manual testing - will be removed before merging.
Run pnpm hardhat run scripts/demo-trace-output.ts -vvvv (or -vvvvv) in example-project to see a demo
There was a problem hiding this comment.
Actually, I will keep them, it could be useful for the future
ChristopherDedominici
force-pushed
the
improve-verbosity-style
branch
from
6901b54 to
b850538
Compare
ChristopherDedominici
force-pushed
the
improve-verbosity-style
branch
from
3a085ac to
e84d0a8
Compare
| return lines; | ||
| } | ||
|
|
||
| function formatKind(kind: CallKind): string | undefined { |
There was a problem hiding this comment.
move and re-organized at line 127 in this file
…nto improve-verbosity-style
| includeCallTraces !== IncludeTraces.None; | ||
|
|
||
| let traceOutput: TraceOutputManager | undefined; | ||
| if (tracesEnabled) { |
There was a problem hiding this comment.
So we never do response.getCallTraces() if not needed, right?
There was a problem hiding this comment.
Correct
| this.#traceOutput?.clearTracedHashes(); | ||
| // Detach the snapshot-revert listener so nothing keeps a reference | ||
| // to this instance and it can be garbage collected. | ||
| this.removeAllListeners(EDR_NETWORK_REVERT_SNAPSHOT_EVENT); |
There was a problem hiding this comment.
This will conflict with another PR where we remove all listeners, not just this one.
There was a problem hiding this comment.
Removed, restored with original behavior
…nto improve-verbosity-style
ChristopherDedominici
merged commit 96b785c
into
edr-upgrade-25
ChristopherDedominici
changed the title
3 participants
Related to design doc: https://www.notion.so/nomicfoundation/Verbosity-via-vvv-319578cdeaf5805b8255ee9e24664add
This PR is on top of this PR.
In this PR, only the graphical style of
-vis modified.Run example
Run
pnpm hardhat run scripts/demo-trace-output.ts -vvvv(or -vvvvv) inexample-projectScreenshosts
Traces from the example
demo-trace-output.tswith-vvvv: