Modernizations and strictness improvements#464
Merged
bors[bot] merged 17 commits intoNixOS:masterfrom Feb 21, 2023
Merged
Conversation
Enable to parse the header file on its own, e.g. for language servers (clangd).
Make the behavior of functions more explicit.
Avoid creating a stringstream by using find().
Also declare the function static and warn if return value not used.
Prevent overflows in the addtion of q and size, and avoid truncations in callers by using size_t as type for size.
Enable common additional compiler warnings.
Abort on truncation of values being written to the ELF data, to prevent silent behavior mismatch.
Use auto to avoid implicit type conversion, hiding possible value truncation.
Reject ELF data that would lead to invalid memory access or integer overflows.
Mic92
reviewed
Feb 21, 2023
| while ((portion = read(fd, contents->data() + bytesRead, size - bytesRead)) > 0) | ||
| bytesRead += portion; | ||
|
|
||
| close(fd); |
Member
There was a problem hiding this comment.
This could be even autoclosed later on.
Member
|
Thank. Very appreciated. bors merge |
Member
|
bors merge |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Wcast-qualconst