Closed
Conversation
remove package-list-no-aliases this will also save us an eval Closes NixOS#575
Member
Author
|
one issue with this may be that no ci will eval the aliases file? |
Member
Author
|
also is this correct or does the allowAliases config need to be passed to all the eval checks? |
Member
Author
|
making a another pr which does this better and will still catch errors in aliases.nix |
Artturin
added a commit
to Artturin/ofborg
that referenced
this pull request
Apr 20, 2022
this allows ofborg to still check the aliases.nix file for errors unlike NixOS#594 which would have disabled aliases in outpaths.nix errors in the alias.nix file are caught by outpaths.nix eval so we can disable aliases here
cole-h
pushed a commit
that referenced
this pull request
Apr 22, 2022
this allows ofborg to still check the aliases.nix file for errors unlike #594 which would have disabled aliases in outpaths.nix errors in the alias.nix file are caught by outpaths.nix eval so we can disable aliases here
This was referenced Jun 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove package-list-no-aliases
this will also save us an eval
Closes #575
Supersedes #572 #539