ofborg: post a finished check if evaluation starts by Mic92 · Pull Request #527 · NixOS/ofborg

Mic92 · 2020-08-05T07:54:38Z

We need this for better integration into github.

cole-h · 2020-08-05T17:12:05Z

This wouldn't give a PR the "all clear" (green check) because overall_status would still be pending, correct?

Mic92 · 2020-08-05T21:13:47Z

This wouldn't give a PR the "all clear" (green check) because overall_status would still be pending, correct?

Exactly it's posted right after the initial pending status.

cole-h

Should be fine, but I'd like to hear what @grahamc has to say (if anything).

zowoq · 2020-08-06T17:37:46Z

Didn't Graham say he'd be AFK for a while this month? Hasn't been active on github or irc for a week.

Mic92 · 2020-08-06T19:46:07Z

cc @LnL7

zowoq · 2020-08-07T03:41:36Z

NixOS/nixpkgs@5ca7be3

I've bumped the timeout from 30min to 45min as we're still getting builds going red.

Update: I've just reset a bunch of PRs that timed out at 45mins.

cole-h · 2020-08-11T01:57:09Z

Just a quick note: I'm in favor of merging this, but I just tried to redeploy to get our 3rd evaluator back, which failed.

Even if I did merge this, nothing would change until Graham has time to look into the deployment problem, so I'll just wait for him to be available again and 1) have him look at that; and 2) comment on this PR (if necessary).

zowoq · 2020-08-11T02:26:50Z

NixOS/nixpkgs#95126

Lets disable the actions until this is resolved so we don't have pages of red PRs.

zowoq · 2020-08-21T14:11:31Z

What do we think about using actions to manually set a pending status without a timeout that is then cleared as part of this step?

There would be two actions statuses, one for the pending job and another from the job that sets it.

Mic92 · 2020-08-21T14:31:42Z

What do we think about using actions to manually set a pending status without a timeout that is then cleared as part of this step?

There would be two actions statuses, one for the pending job and another from the job that sets it.

That would work too and is probably the better solution.

Mic92 · 2020-08-21T14:33:11Z

What do we think about using actions to manually set a pending status without a timeout that is then cleared as part of this step?
There would be two actions statuses, one for the pending job and another from the job that sets it.

That would work too and is probably the better solution.

I am not quite sure if it is possible so because the github token in github actions comes from the user that opens the pull request.

zowoq · 2020-08-21T14:42:15Z

https://docs.github.com/en/actions/reference/events-that-trigger-workflows#pull_request_target

This event is similar to pull_request, except that it runs in the context of the base repository of the pull request, rather than in the merge commit. This means that you can more safely make your secrets available to the workflows triggered by the pull request, because only workflows defined in the commit on the base repository are run.

Hopefully this would allow us to use a token in PRs?

Mic92 · 2020-08-21T18:22:25Z

docs.github.com/en/actions/reference/events-that-trigger-workflows#pull_request_target
This event is similar to pull_request, except that it runs in the context of the base repository of the pull request, rather than in the merge commit. This means that you can more safely make your secrets available to the workflows triggered by the pull request, because only workflows defined in the commit on the base repository are run.

Hopefully this would allow us to use a token in PRs?

Yes. This sounds great. We could also use this for cachix. We could even implement this without using ofborg:

Having a workflow that just creates a Waiting for ofborg task
Use a second action that mark the first as complete if the ofborg suite is complete https://docs.github.com/en/actions/reference/events-that-trigger-workflows#check_suite

Mic92 · 2020-08-25T07:02:08Z

I will update this PR to mark the Wait for ofborg as non-pending once this project is maintained again.

worldofpeace · 2020-09-05T18:11:14Z

ping @grahamc

zowoq · 2020-12-02T03:09:49Z

@grahamc If we're going to start running more actions in PRs it would be nice to get this resolved.

zowoq · 2021-01-28T09:01:35Z

Ping @cole-h @grahamc

cc @SuperSandro2000

SuperSandro2000 · 2021-01-28T14:25:33Z

Why did you ping me?

zowoq · 2021-01-28T23:20:55Z

Sorry, meant to link to IRC. This PR would address your comment about wait for ofborg: https://logs.nix.samueldr.com/nixos-borg/2021-01-27#4546552

ofborg/src/tasks/evaluate.rs

andir

It is a bit unfortunate that we need this bit of code at all. Thanks to GitHubs limited external CI API. That being said this looks simple enough and solves a real-world pain that several people have noticed and disliked (myself included).

Until we have a way to signal that we started doing our job this seems like the best solution.

worldofpeace

If yall don't merge this 🤣

We need this for better integration into github.

cole-h

Diff LGTM, thanks.

cole-h · 2021-01-29T16:58:18Z

ofborg/src/tasks/evaluate.rs

+    Ok(CommitStatus::new(
+        api,
+        commit,
+        "ofborg-eval-started".to_owned(),


Graham has expressed the desire to remove the grahamc prefix from all the ofborg checks (https://twitter.com/grhmc/status/1353171107550027776 as a recent example), so I decided to do that for this new one here.

cole-h · 2021-01-29T17:08:09Z

Note that I haven't deployed this change yet. In order to streamline this: which PR, if any, needs to be merged after the deploy succeeds?

zowoq · 2021-01-30T01:29:35Z

which PR, if any, needs to be merged after the deploy succeeds?

NixOS/nixpkgs#96707

cole-h · 2021-01-30T06:27:49Z

Done.

Mic92 mentioned this pull request Aug 5, 2020

.github/workflows: add build action NixOS/nixpkgs#94658

Closed

10 tasks

cole-h approved these changes Aug 6, 2020

View reviewed changes

cole-h requested a review from grahamc August 6, 2020 17:23

Mic92 mentioned this pull request Aug 10, 2020

drone-cli: 1.2.1 -> 1.2.2 NixOS/nixpkgs#95042

Closed

zowoq mentioned this pull request Aug 11, 2020

.github/workflows: disable NixOS/nixpkgs#95126

Merged

zowoq mentioned this pull request Aug 23, 2020

.github/workflows: pending-{set,clear} NixOS/nixpkgs#96056

Merged

worldofpeace mentioned this pull request Aug 30, 2020

Wait for ofborg check sets a failed status when pending NixOS/nixpkgs#96695

Closed

zowoq mentioned this pull request Aug 30, 2020

.github/workflows/pending-set.yml: failed -> pending NixOS/nixpkgs#96707

Merged

zowoq mentioned this pull request Oct 11, 2020

rm .github/workflows/pending-* NixOS/nixpkgs#100269

Closed

andir reviewed Jan 29, 2021

View reviewed changes

ofborg/src/tasks/evaluate.rs Outdated Show resolved Hide resolved

andir approved these changes Jan 29, 2021

View reviewed changes

worldofpeace approved these changes Jan 29, 2021

View reviewed changes

ofborg: post a finished check if evaluation starts

3e51dc3

We need this for better integration into github.

cole-h approved these changes Jan 29, 2021

View reviewed changes

cole-h merged commit 16355e1 into NixOS:released Jan 29, 2021

This was referenced Oct 14, 2022

.github/workflows: use ofborg-eval context for pending status NixOS/nixpkgs#195984

Merged

Revert "ofborg: post a finished check if evaluation starts" #617

Merged

Uh oh!

Comments

Conversation

Mic92 commented Aug 5, 2020

Uh oh!

cole-h commented Aug 5, 2020

Uh oh!

Mic92 commented Aug 5, 2020

Uh oh!

cole-h left a comment

Choose a reason for hiding this comment

Uh oh!

zowoq commented Aug 6, 2020

Uh oh!

Mic92 commented Aug 6, 2020

Uh oh!

zowoq commented Aug 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cole-h commented Aug 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zowoq commented Aug 11, 2020

Uh oh!

zowoq commented Aug 21, 2020

Uh oh!

Mic92 commented Aug 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mic92 commented Aug 21, 2020

Uh oh!

zowoq commented Aug 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mic92 commented Aug 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mic92 commented Aug 25, 2020

Uh oh!

worldofpeace commented Sep 5, 2020

Uh oh!

zowoq commented Dec 2, 2020

Uh oh!

zowoq commented Jan 28, 2021

Uh oh!

SuperSandro2000 commented Jan 28, 2021

Uh oh!

zowoq commented Jan 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

andir left a comment

Choose a reason for hiding this comment

Uh oh!

worldofpeace left a comment

Choose a reason for hiding this comment

Uh oh!

cole-h left a comment

Choose a reason for hiding this comment

Uh oh!

cole-h Jan 29, 2021

Choose a reason for hiding this comment

Uh oh!

cole-h commented Jan 29, 2021

Uh oh!

zowoq commented Jan 30, 2021

Uh oh!

cole-h commented Jan 30, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

zowoq commented Aug 7, 2020 •

edited

Loading

cole-h commented Aug 11, 2020 •

edited

Loading

Mic92 commented Aug 21, 2020 •

edited

Loading

zowoq commented Aug 21, 2020 •

edited

Loading

Mic92 commented Aug 21, 2020 •

edited

Loading

zowoq commented Jan 28, 2021 •

edited

Loading