Make ofborg able to (un)label issues and PRs#164
Closed
Ekleog wants to merge 2 commits intoNixOS:nextfrom
Closed
Conversation
LnL7
reviewed
May 3, 2018
Member
LnL7
left a comment
LnL7
left a comment
There was a problem hiding this comment.
Looks good, but I can't say much about the consumer part.
| hyper = "0.10.*" | ||
| hyper-native-tls = "0.2.4" | ||
| lru-cache = "0.1.1" | ||
| nom = "4.0.0-beta3" |
Member
There was a problem hiding this comment.
The carnix expressions should also be updated.
LnL7
reviewed
May 3, 2018
| let mut channel = session.open_channel(1).unwrap(); | ||
|
|
||
| // TODO: I have no idea what I'm doing, this is basically github-comment-parser | ||
| // adapted in a "let's hope this will work" fashion. |
Member
There was a problem hiding this comment.
@grahamc Could you take a look at this (mostly the last commit).
9 tasks
Member
|
Why was this closed? |
Member
|
I deleted the branch it was being merged in to.
…Sent from my iPhone
On Aug 9, 2018, at 4:09 PM, Timo Kaufmann ***@***.***> wrote:
Why was this closed?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Member
|
Couldn't the base just be changed then? |
Member
|
It could but GitHub closed it on my behalf. I didn’t explicitly choose to close this.
…Sent from my iPhone
On Aug 9, 2018, at 6:08 PM, Timo Kaufmann ***@***.***> wrote:
Couldn't the base just be changed then?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Member
Author
|
I've reopened as #216 ; sorry for not having found time to get back to this yet :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an
@ofborg label [label-id]command that tags the PR/issue aslabel(after alabel-id→labeltranslation phase), via a dedicated worker so that response can be instantaneous even if the builders are all in use.Still missing:
Review should be easier commit-by-commit :)
(This builds upon #124)