Merged
Conversation
infinisil
force-pushed
the
file-ratchet-check
branch
from
22603ba to
00815fa
Compare
For a future change we need a version that gives access to the Success value from both arguments.
infinisil
force-pushed
the
file-ratchet-check
branch
from
00815fa to
30686e7
Compare
Member
Author
|
After very minor changes and adding code comments, I think this PR is ready. While it doesn't introduce any functionality by itself, it's going to be very useful to have this for #142 and similar features. In particular #135 could also be based on this.
nixpkgs-vet/.github/workflows/main.yml Lines 50 to 51 in 93a073d |
A future commit introduces checks on all Nix files, but this is problematic if the base Nixpkgs version is part of the main Nixpkgs version
infinisil
force-pushed
the
file-ratchet-check
branch
from
30686e7 to
6b52b12
Compare
philiptaron
approved these changes
Jan 23, 2025
Contributor
philiptaron
left a comment
philiptaron
left a comment
There was a problem hiding this comment.
No blocking comments, just a few clarifying questions. Thanks for your patience in waiting for a review.
Comment on lines
+17
to
+18
| // Noop for now, only boilerplate to make it easier to add future file-based checks | ||
| Ok(Success(ratchet::File {})) |
Member
Author
There was a problem hiding this comment.
This is where the logic goes yes :)
For now without any checks, but this makes introducing ones fairly easy
infinisil
force-pushed
the
file-ratchet-check
branch
from
6b52b12 to
11fb3da
Compare
philiptaron
approved these changes
Jan 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces the boilerplate to support ratchet (and non-ratchet) checks for all Nix files in Nixpkgs, which can be used as a basis for #142
This includes #143
Needs some code comments probably before ready for mergingAdded
This work is funded by Tweag and Antithesis ✨