nixos/grub-install: execute prepare commands earlier#99618
Draft
andir wants to merge 1 commit intoNixOS:masterfrom
Draft
nixos/grub-install: execute prepare commands earlier#99618andir wants to merge 1 commit intoNixOS:masterfrom
andir wants to merge 1 commit intoNixOS:masterfrom
Conversation
Previously the extraPrepareConfig commands where exectued after the grub entries were generated. With this new location we can run commands before the initrd appender scripts is executed. This is especially helpful with the recent change to the sshd host keys of openssh in the initrd. In the old setup you did not have to provision host keys (and you might not even have cared about them) but with the new setup you must always provide host keys even if you do not care about them. In my personal setup I have everything encrypted except that initrd. The initrd is basically public knowledge as anyone (on the hosting provider) will be able to read that key from the initrd.
ofborg
bot
added
6.topic: nixos
10 tasks
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
wegank
added
the
2.status: merge conflict
stale
bot
removed
the
2.status: stale
wegank
added
the
2.status: stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Previously the extraPrepareConfig commands where exectued after the grub
entries were generated. With this new location we can run commands
before the initrd appender scripts is executed. This is especially
helpful with the recent change to the sshd host keys of openssh in the
initrd. In the old setup you did not have to provision host keys (and
you might not even have cared about them) but with the new setup you
must always provide host keys even if you do not care about them.
In my personal setup I have everything encrypted except that initrd. The
initrd is basically public knowledge as anyone (on the hosting provider)
will be able to read that key from the initrd.
cc @mweinelt #98100