Skip to content

systemd: create options for smaller derivation#98998

Merged
Ericson2314 merged 1 commit intoNixOS:stagingfrom
kloenk:systemd-module
Oct 10, 2020
Merged

systemd: create options for smaller derivation#98998
Ericson2314 merged 1 commit intoNixOS:stagingfrom
kloenk:systemd-module

Conversation

@kloenk
Copy link
Member

@kloenk kloenk commented Sep 28, 2020

Motivation for this change

Base work for #98299

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

flokli
flokli reviewed Sep 28, 2020
View reviewed changes
@flokli
Copy link
Member

flokli commented Sep 30, 2020

@kloenk any chance you could keep this udev = systemd (but update the comment)? Maybe that's also what fails evaluation currently.

Otherwise I'd also gladly massage this in shape :-)

@kloenk
Copy link
Member Author

kloenk commented Sep 30, 2020

I can change that. But bigger changes have to wait a little. (School takes much time currently)

@kloenk
Copy link
Member Author

kloenk commented Sep 30, 2020

@flokli
replace, or add to the comment?

@flokli
Copy link
Member

flokli commented Sep 30, 2020

I'd propose to have that line look like this:

 udev = systemd; # TODO: change to systemdMinimal

So this shouldn't cause any breakage, and we have systemdMinimal available for other tasks.

I can change that. But bigger changes have to wait a little. (School takes much time currently)

No worries!

@kloenk kloenk marked this pull request as ready for review September 30, 2020 15:18
@kloenk kloenk requested a review from flokli September 30, 2020 15:19
flokli
flokli reviewed Sep 30, 2020
View reviewed changes
@flokli
Copy link
Member

flokli commented Sep 30, 2020

Sorry, I missed this - this is a mass rebuild, so it'll need to target staging.

@kloenk kloenk changed the base branch from master to staging September 30, 2020 16:28
arianvp
arianvp reviewed Oct 1, 2020
View reviewed changes
Ericson2314
Ericson2314 approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@Ericson2314 Ericson2314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with all our recent systemd decisions. But this PR makes sense to me, and I'm eager to try out homed in the one that depends on it.

@kloenk says the ofborg failure doesn't reproduce locally, so I suspect this is due to ofborg merging a broken master/staging.

@kloenk kloenk requested a review from arianvp October 6, 2020 20:26
@kloenk
Copy link
Member Author

kloenk commented Oct 8, 2020

rebased, hopefully this fixes ofborg-eval

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Oct 8, 2020
@ofborg ofborg bot requested review from andir, edolstra and flokli October 8, 2020 13:48
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Oct 8, 2020
@gdamjan gdamjan mentioned this pull request Oct 8, 2020
Open
@kloenk kloenk mentioned this pull request Oct 10, 2020
Merged
10 tasks
@Ericson2314
Copy link
Member

Ericson2314 commented Oct 10, 2020

Ah good with the udev = systemd; # TODO: change to systemdMinimal this really is quite minimal. I'll just merge then.

In any event, I'm always for exposing more flags on the nix expr level. It gives gentoo people less reason to complain about us :D.

@Ericson2314 Ericson2314 merged commit db3b1c1 into NixOS:staging Oct 10, 2020
@flokli flokli mentioned this pull request Dec 25, 2020
Closed
10 tasks
@andersk andersk mentioned this pull request Feb 14, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ericson2314 Ericson2314 Ericson2314 approved these changes

@arianvp arianvp Awaiting requested review from arianvp

@flokli flokli Awaiting requested review from flokli

@andir andir Awaiting requested review from andir

@edolstra edolstra Awaiting requested review from edolstra

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

systemd
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kloenk @flokli @Ericson2314 @arianvp