Merged
Conversation
It is no longer necessary to build vlc with every Qt version now that we have a Qt-less libvlc.
ofborg
bot
added
6.topic: python
ofborg
bot
added
8.has: clean-up
ofborg
bot
added
10.rebuild-darwin: 1-10
ttuegel
added a commit
to ttuegel/nixpkgs
that referenced
this pull request
Sep 26, 2020
Build standalone libvlc (cherry picked from commit 6882716)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Use standalone libvlc instead of full VLC to reduce dependence on Qt and unnecessary rebuilds.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)