Skip to content

Comments

firefox-bin/update: fix#98338

Merged
stigtsp merged 2 commits intoNixOS:masterfrom
Atemu:firefox-bin-update-fix
Oct 24, 2020
Merged

firefox-bin/update: fix#98338
stigtsp merged 2 commits intoNixOS:masterfrom
Atemu:firefox-bin-update-fix

Conversation

@Atemu
Copy link
Member

@Atemu Atemu commented Sep 20, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Mozilla has ended the gpg.mozilla.org SKS server and the key can't be imported
from keys.openpgp.org because it lacks a user ID because Mozilla hasn't verified
their email...

Since the key isn't going to change any time soon and SKS is mostly busted,
might as well hard-code it.
@Atemu
Copy link
Member Author

Atemu commented Sep 20, 2020

EditorConfig check getting confused by the binary file :/

@Atemu Atemu requested a review from alyssais September 20, 2020 18:47
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Sep 20, 2020
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mozilla.asc in 2b44f56 matches:

pub   rsa4096/61B7B526D98F0353 2015-07-17 [SC]
      Key fingerprint = 14F2 6682 D091 6CDD 81E3  7B6D 61B7 B526 D98F 0353
uid                 [ unknown] Mozilla Software Releases <[email protected]>
sub   rsa4096/F1A6668FBB7D572E 2019-05-30 [S] [expires: 2021-05-29]

Btw, gpgv can use the keyring directly as long as its not armored.

$ gpg -o mozilla.gpg --dearmor mozilla.asc
$ gpgv --keyring=$(pwd)/mozilla.gpg SHA256SUMS.asc SHA256SUMS
gpgv: Signature made Mon 31 Aug 2020 10:59:13 PM CEST
gpgv:                using RSA key 097B313077AE62A02F84DA4DF1A6668FBB7D572E
gpgv: Good signature from "Mozilla Software Releases <[email protected]>"

@Atemu
Copy link
Member Author

Atemu commented Oct 3, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Oct 3, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tested OK, checked key.

nix-shell maintainers/scripts/update.nix --argstr package firefox-bin-unwrapped

Copy link
Contributor

@taku0 taku0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works with thunderbird-bin.

nix-shell maintainers/scripts/update.nix --argstr package pkgs.thunderbird-bin-78

@stigtsp stigtsp merged commit 7ecdf14 into NixOS:master Oct 24, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Oct 24, 2020
firefox-bin/update: fix

(cherry picked from commit 7ecdf14)
@andir
Copy link
Member

andir commented Oct 24, 2020

I tried using this on Firefox but the upgrade script just block at some point and even after 20 minutes nothing happened. Does it work for anyone else on Firefox?

@andir andir mentioned this pull request Oct 24, 2020
10 tasks
taku0 added a commit to taku0/nixpkgs that referenced this pull request Oct 25, 2020
@taku0 taku0 mentioned this pull request Oct 25, 2020
10 tasks
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Nov 9, 2020
@Atemu Atemu deleted the firefox-bin-update-fix branch September 23, 2021 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants