portmod: init at 2.0_beta7 by marius851000 · Pull Request #98093 · NixOS/nixpkgs

marius851000 · 2020-09-16T11:48:14Z

Motivation for this change

wanted to add the portmod package. I use it, and wanted it to be in the nixpkgs.

Things done

mainly in additional to portmod, add patool.

I was able to install the meta-momw/expanded-vanilla , but with some modification in the environment: needed to set "TMPDIR=/tmp" (the default temp dir doesn't have enought size) and to have unrar in the PATH.

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
[] Ensured that relevant documentation is up to date
Fits CONTRIBUTING.md.

IvarWithoutBones · 2020-09-16T13:43:47Z

Result of nixpkgs-review pr 98093 1

1 package failed to build:

python27Packages.redbaron

15 packages built:

patool (python38Packages.patool)
portmod
python27Packages.baron
python27Packages.patool
python27Packages.pypblib
python27Packages.python-sat
python37Packages.baron
python37Packages.patool
python37Packages.pypblib
python37Packages.python-sat
python37Packages.redbaron
python38Packages.baron
python38Packages.pypblib
python38Packages.python-sat
python38Packages.redbaron

python27Packages.redbaron error:

[2/11/31 built, 149 copied (1588.1/1588.6 MiB), 285.6 MiB DL] building python3.7-python-sat-0.1.6.dev6 (buildPhase): |       ^~~
builder for '/nix/store/1pi10m6myd6rcjw7k5iz9nxwm16nzsdr-python2.7-redbaron-0.9.2.drv' failed with exit code 2; last 10 log lines:
  HINT: remove __pycache__ / .pyc files and/or use a unique basename for your test file modules
  ____________________ ERROR collecting tests/test_setter.py _____________________
  import file mismatch:
  imported module 'tests.test_setter' has this __file__ attribute:
    /home/psycojoker/code/python/redbaron/tests/test_setter.py
  which is not the same as the test file we want to collect:
    /build/redbaron-0.9.2/tests/test_setter.py
  HINT: remove __pycache__ / .pyc files and/or use a unique basename for your test file modules
  !!!!!!!!!!!!!!!!!!! Interrupted: 13 errors during collection !!!!!!!!!!!!!!!!!!!
  =========================== 13 error in 8.46 seconds ===========================
cannot build derivation '/nix/store/jx4pgvd31fy01ldzvplk4kg8qizcf7xh-env.drv': 1 dependencies couldn't be built
[29 built (1 failed), 149 copied (1588.1 MiB), 285.6 MiB DL]
error: build of '/nix/store/jx4pgvd31fy01ldzvplk4kg8qizcf7xh-env.drv' failed

marius851000 · 2020-09-17T16:09:29Z

that should be fixed, thank.

IvarWithoutBones

Result of nixpkgs-review pr 98093 1

16 packages built:

patool (python38Packages.patool)
portmod
python27Packages.baron
python27Packages.patool
python27Packages.pypblib
python27Packages.python-sat
python27Packages.redbaron
python37Packages.baron
python37Packages.patool
python37Packages.pypblib
python37Packages.python-sat
python37Packages.redbaron
python38Packages.baron
python38Packages.pypblib
python38Packages.python-sat
python38Packages.redbaron

pkgs/development/python-modules/baron/default.nix

pkgs/development/python-modules/patool/default.nix

pkgs/development/python-modules/pypblib/default.nix

pkgs/development/python-modules/python-sat/default.nix

pkgs/development/python-modules/redbaron/default.nix

pkgs/top-level/all-packages.nix

jonringer · 2020-09-18T17:15:45Z

I take back the hash reviews, apparently master has been updated with a minver which supports 64bit base hashes

marius851000 · 2020-09-21T10:46:42Z

Thank. I fixed the issue you reported (exluding the hash). Now I know why hash are shorter now.
Seem baron have issue with python 2.7. Will solve this.
solved !

pkgs/development/python-modules/pypblib/default.nix

pkgs/development/python-modules/python-sat/default.nix

marius851000 · 2020-09-25T11:00:55Z

That's done. Thank again.

doronbehar · 2020-10-12T17:31:44Z

There's an editor config issue - https://github.com/NixOS/nixpkgs/pull/98093/checks?check_run_id=1165438542

marius851000 · 2020-10-13T08:41:04Z

Thank. Didn't noticed this.

pkgs/development/python-modules/python-sat/default.nix

pkgs/development/python-modules/redbaron/default.nix

pkgs/games/portmod/tr-patcher.nix

pkgs/games/portmod/default.nix

pkgs/development/python-modules/python-sat/default.nix

pkgs/development/python-modules/patool/default.nix

pkgs/development/python-modules/pypblib/default.nix

pkgs/development/python-modules/patool/default.nix

doronbehar · 2020-10-17T08:06:04Z

pkgs/games/portmod/default.nix

I think those would be worth something if exposed in all-packages.nix (And be added in separate commits of their own).

Should I put them into different folder, or should I import call the file that are in the portmod subdir ?

pkgs/development/python-modules/patool/default.nix

pkgs/development/python-modules/redbaron/default.nix

doronbehar

Small nitpicks. Besides that all is good.

pkgs/development/python-modules/python-sat/default.nix

pkgs/games/tr-patcher/default.nix

pkgs/games/tes3cmd/default.nix

doronbehar · 2020-10-21T05:49:51Z

A few issues with the executables:

$ ./results/portmod/bin/inquisitor
ERROR: Cannot find repository for the current directory. Please run from within the repository you wish to inspect
Traceback (most recent call last):
  File "/nix/store/wnp22084acnxvf8mb79ff04d7g8igzln-portmod-2.0_beta9/bin/.inquisitor-wrapped", line 9, in <module>
    sys.exit(main())
  File "/nix/store/wnp22084acnxvf8mb79ff04d7g8igzln-portmod-2.0_beta9/lib/python3.8/site-packages/portmod/inquisitor.py", line 200, in main
    REAL_ROOT = os.path.realpath(repo_root)
  File "/nix/store/346skv0d24rqnf4npknbp9h5bs14j8zy-python3-3.8.6/lib/python3.8/posixpath.py", line 390, in realpath
    filename = os.fspath(filename)
TypeError: expected str, bytes or os.PathLike object, not NoneType

$ ./results/portmod/bin/openmw-conflicts
Traceback (most recent call last):
  File "/nix/store/wnp22084acnxvf8mb79ff04d7g8igzln-portmod-2.0_beta9/bin/.openmw-conflicts-wrapped", line 9, in <module>
    sys.exit(main())
  File "/nix/store/wnp22084acnxvf8mb79ff04d7g8igzln-portmod-2.0_beta9/lib/python3.8/site-packages/portmod/openmw_conflicts.py", line 17, in main
    mod_dirs = get_vfs_dirs()
  File "/nix/store/wnp22084acnxvf8mb79ff04d7g8igzln-portmod-2.0_beta9/lib/python3.8/site-packages/portmod/vfs.py", line 111, in get_vfs_dirs
    return read_list(os.path.join(env.MOD_DIR, "vfs"))
  File "/nix/store/wnp22084acnxvf8mb79ff04d7g8igzln-portmod-2.0_beta9/lib/python3.8/site-packages/portmod/repo/list.py", line 12, in read_list
    with open(listpath, mode="r") as list_file:
FileNotFoundError: [Errno 2] No such file or directory: '/home/doron/.local/share/portmod/mods/vfs'

All other executables from new packages in this PR are fine as far as --help is concerned. Is this an issue @marius851000 ? or is this an expected behavior due to not found paths?

marius851000 · 2020-10-22T09:01:29Z

inquisitor need to be run inside a package repository (there is one at https://gitlab.com/portmod/openmw-mods )

I have no idea what the second did, but it worked well on my side. I indeed have a ~/.local/share/portmod/mods/vfs . I suppose that can be solve by installing a package.

marius851000 requested review from FRidh and jonringer as code owners September 16, 2020 11:48

marius851000 force-pushed the portmod branch from 97f72bd to 829dd5b Compare September 17, 2020 16:05

IvarWithoutBones approved these changes Sep 18, 2020

View reviewed changes

jonringer reviewed Sep 18, 2020

View reviewed changes

marius851000 force-pushed the portmod branch from 829dd5b to ad34a75 Compare September 21, 2020 10:45

marius851000 force-pushed the portmod branch from ad34a75 to adc330d Compare September 21, 2020 11:15

jonringer reviewed Sep 21, 2020

View reviewed changes

pkgs/development/python-modules/pypblib/default.nix Outdated Show resolved Hide resolved

pkgs/development/python-modules/python-sat/default.nix Outdated Show resolved Hide resolved

marius851000 force-pushed the portmod branch from adc330d to b6ac9a3 Compare September 25, 2020 10:59

marius851000 force-pushed the portmod branch from b6ac9a3 to 32de6c5 Compare October 13, 2020 08:14

doronbehar requested changes Oct 13, 2020

View reviewed changes

doronbehar mentioned this pull request Oct 14, 2020

rm .github/workflows/pending-* #100269

Closed

marius851000 force-pushed the portmod branch from 32de6c5 to 3063c18 Compare October 17, 2020 07:48

doronbehar requested changes Oct 17, 2020

View reviewed changes

pythonPackages.pypblib: init at 0.0.4

487c190

marius851000 force-pushed the portmod branch from 3063c18 to 71d7e97 Compare October 17, 2020 08:52

doronbehar requested changes Oct 17, 2020

View reviewed changes

pkgs/development/python-modules/python-sat/default.nix Outdated Show resolved Hide resolved

pkgs/games/tr-patcher/default.nix Outdated Show resolved Hide resolved

pkgs/games/tr-patcher/default.nix Outdated Show resolved Hide resolved

jonringer reviewed Oct 17, 2020

View reviewed changes

pkgs/games/tr-patcher/default.nix Outdated Show resolved Hide resolved

pkgs/games/tes3cmd/default.nix Outdated Show resolved Hide resolved

marius851000 added 5 commits October 18, 2020 10:30

python3Packages.python-sat: init at 0.1.6.dev6

1c8204e

python3Packages.baron: init at 0.9

eca871c

python3Packages.redbaron: init at 0.9.2

f4a5881

patool: init at 1.12

9c17a54

tes3cmd: init at 0.40-pre-release-2

e71198d

marius851000 force-pushed the portmod branch from 71d7e97 to 4a2a407 Compare October 18, 2020 08:42

marius851000 added 2 commits October 18, 2020 11:10

tr-patcher: init at 1.0.5

27c87b0

portmod: init at 2.0_beta9

aa442d0

marius851000 force-pushed the portmod branch from 4a2a407 to aa442d0 Compare October 18, 2020 09:10

doronbehar merged commit 44dd65f into NixOS:master Oct 22, 2020

This was referenced Nov 22, 2020

Add patool package #64778

Closed

patool: init at 1.12 #73209

Closed

Uh oh!

Conversation

marius851000 commented Sep 16, 2020

Motivation for this change

Things done

Uh oh!

IvarWithoutBones commented Sep 16, 2020

Uh oh!

marius851000 commented Sep 17, 2020

Uh oh!

IvarWithoutBones left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jonringer commented Sep 18, 2020

Uh oh!

marius851000 commented Sep 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marius851000 commented Sep 25, 2020

Uh oh!

doronbehar commented Oct 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marius851000 commented Oct 13, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

doronbehar Oct 17, 2020

Choose a reason for hiding this comment

Uh oh!

marius851000 Oct 17, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

doronbehar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

doronbehar commented Oct 21, 2020

Uh oh!

marius851000 commented Oct 22, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

marius851000 commented Sep 21, 2020 •

edited

Loading

doronbehar commented Oct 12, 2020 •

edited

Loading