Skip to content

mailpile service: allow multiple instances#97275

Closed
Twey wants to merge 2 commits intoNixOS:masterfrom
Twey:mailpile-multiple-instances
Closed

mailpile service: allow multiple instances#97275
Twey wants to merge 2 commits intoNixOS:masterfrom
Twey:mailpile-multiple-instances

Conversation

@Twey
Copy link
Contributor

@Twey Twey commented Sep 6, 2020

This PR generalizes the Mailpile service to allow it to be used to run multiple instances of Mailpile, each with a separate user.

It breaks the Mailpile service config, but as the Mailpile package was previously marked as having known vulnerabilities, I think this is okay.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Twey Twey force-pushed the mailpile-multiple-instances branch from a06c901 to ce0c4e7 Compare September 6, 2020 03:42
@Twey Twey changed the title Mailpile multiple instances mailpile service: allow multiple instances Sep 6, 2020
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 6, 2020
@Twey Twey force-pushed the mailpile-multiple-instances branch from ce0c4e7 to f0ee5e7 Compare September 11, 2020 17:51
@stale
Copy link

stale bot commented Mar 16, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 16, 2021
mweinelt added a commit to mweinelt/nixpkgs that referenced this pull request Jan 16, 2022
@mweinelt
mailpile, nixos/mailpile: drop
369db3b 
Still actively developed and yet stuck on python2. Also marked as
vulnerable and their issue tracker contains yet another security issue
reported in 2021/10 that the upstream hasn't acknowledged yet.

Mind blown.

Closes: NixOS#135543, NixOS#97274, NixOS#97275
@rapenne-s
Copy link
Member

rapenne-s commented Oct 19, 2022

mailpile has been removed 369db3b

@rapenne-s rapenne-s closed this Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Twey @rapenne-s