Skip to content

mailpile: 1.0.0rc2 -> 1.0.0rc6#97274

Closed
Twey wants to merge 1 commit intoNixOS:masterfrom
Twey:mailpile-1.0.0rc6
Closed

mailpile: 1.0.0rc2 -> 1.0.0rc6#97274
Twey wants to merge 1 commit intoNixOS:masterfrom
Twey:mailpile-1.0.0rc6

Conversation

@Twey
Copy link
Contributor

@Twey Twey commented Sep 6, 2020 •
edited
Loading

This PR also removes the meta.knownVulnerabilities metadata from the package. The referenced discussion thread talks about 0.5.x versions of Mailpile; 1.0.0rc* are stated to be ready for packaging.

Atop #97273.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Twey Twey requested review from FRidh and jonringer as code owners September 6, 2020 03:34
@Twey Twey force-pushed the mailpile-1.0.0rc6 branch from b840d01 to 403675c Compare September 6, 2020 03:52
@ofborg ofborg bot added 6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package labels Sep 6, 2020
@ofborg ofborg bot requested a review from domenkozar September 6, 2020 13:50
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 6, 2020
FRidh
FRidh reviewed Sep 6, 2020
View reviewed changes
jonringer
jonringer reviewed Sep 6, 2020
View reviewed changes
@jonringer
Copy link
Contributor

jonringer commented Sep 6, 2020

also, partial duplicate of #97273

@Twey Twey force-pushed the mailpile-1.0.0rc6 branch from 403675c to a9c88ff Compare September 7, 2020 10:08
@Twey
Copy link
Contributor Author

Twey commented Sep 7, 2020

Yes, I intended for #97273 to be merged first, then this atop it — sorry, thought I'd made that clear in the description, but I guess I forgot.

@jonringer
Copy link
Contributor

jonringer commented Sep 7, 2020

please rebase on the latest master, and remove the imgsize commit

@Twey Twey force-pushed the mailpile-1.0.0rc6 branch from a9c88ff to dcdf9b4 Compare September 8, 2020 14:13
@Twey
Copy link
Contributor Author

Twey commented Sep 8, 2020

Have done — eval failure is due to master.

@jonringer
Copy link
Contributor

jonringer commented Sep 8, 2020

there was fixup commit already pushed, do you mind rebasing again?

@Twey Twey force-pushed the mailpile-1.0.0rc6 branch from dcdf9b4 to f335cbd Compare September 9, 2020 21:41
@Twey
Copy link
Contributor Author

Twey commented Sep 9, 2020

Done!

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. and removed 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Sep 10, 2020
SuperSandro2000
SuperSandro2000 reviewed Dec 29, 2020
View reviewed changes
pkgs/applications/networking/mailreaders/mailpile/default.nix
{ stdenv, fetchFromGitHub, python2Packages, gnupg1orig, openssl, git }:
{ stdenv
, fetchFromGitHub
, python2Packages
Copy link
Member

@SuperSandro2000 SuperSandro2000 Dec 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be updated to python3?

Copy link

@reyman reyman Jan 12, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about that, mailpile 1.0 target python 3+, actually don't know where dev are on this point, i ask here : mailpile/Mailpile#160

@SuperSandro2000 SuperSandro2000 added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 18, 2021
@stale
Copy link

stale bot commented Jul 20, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 20, 2021
@ostylk ostylk mentioned this pull request Sep 11, 2021
Closed
12 tasks
mweinelt added a commit to mweinelt/nixpkgs that referenced this pull request Jan 16, 2022
@mweinelt
mailpile, nixos/mailpile: drop
369db3b 
Still actively developed and yet stuck on python2. Also marked as
vulnerable and their issue tracker contains yet another security issue
reported in 2021/10 that the upstream hasn't acknowledged yet.

Mind blown.

Closes: NixOS#135543, NixOS#97274, NixOS#97275
@rapenne-s
Copy link
Member

rapenne-s commented Oct 19, 2022

mailpile has been removed 369db3b

@rapenne-s rapenne-s closed this Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@domenkozar domenkozar Awaiting requested review from domenkozar

+3 more reviewers

@reyman reyman reyman left review comments

@FRidh FRidh FRidh left review comments

@jonringer jonringer jonringer left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Twey @jonringer @rapenne-s @reyman @FRidh @SuperSandro2000