Skip to content

nixos/testing: remove remaining coverage-data logic#97231

Merged
worldofpeace merged 1 commit intoNixOS:masterfrom
flokli:coverage-data-remove
Sep 5, 2020
Merged

nixos/testing: remove remaining coverage-data logic#97231
worldofpeace merged 1 commit intoNixOS:masterfrom
flokli:coverage-data-remove

Conversation

@flokli
Copy link
Member

@flokli flokli commented Sep 5, 2020

This isn't used anymore as per
#72354 (comment).

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli flokli requested review from ajs124, edolstra and tfc September 5, 2020 14:08
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Sep 5, 2020
@worldofpeace worldofpeace merged commit f439dc7 into NixOS:master Sep 5, 2020
@flokli flokli deleted the coverage-data-remove branch September 5, 2020 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/`

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants