Skip to content

unbound: disable lto on static builds#96020

Closed
baloo wants to merge 1 commit intoNixOS:masterfrom
baloo:baloo/unbound/static-build
Closed

unbound: disable lto on static builds#96020
baloo wants to merge 1 commit intoNixOS:masterfrom
baloo:baloo/unbound/static-build

Conversation

@baloo
Copy link
Member

@baloo baloo commented Aug 22, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 22, 2020
vcunat pushed a commit that referenced this pull request Sep 1, 2020
@baloo @vcunat
unbound: disable lto on static builds (PR #96020)
cc1920a 
Signed-off-by: Arthur Gautier <[email protected]>

Amended by vcunat (isMusl != isStatic).
#96223 (comment)
@vcunat
Copy link
Member

vcunat commented Sep 1, 2020

Thanks.

@vcunat vcunat closed this Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@baloo @vcunat