[20.03] tor-browser: disable hardening by default (#93154)#95688
Merged
worldofpeace merged 1 commit intoNixOS:release-20.03from Sep 8, 2020
Merged
[20.03] tor-browser: disable hardening by default (#93154)#95688worldofpeace merged 1 commit intoNixOS:release-20.03from
worldofpeace merged 1 commit intoNixOS:release-20.03from
Conversation
* tor-browser: disable hardening by default this seems to cause crashes with certain tabs. relevant issue: NixOS#86356 * Update pkgs/applications/networking/browsers/tor-browser-bundle-bin/default.nix Co-authored-by: Jörg Thalheim <[email protected]> (cherry picked from commit 45e2ff3)
ofborg
bot
added
10.rebuild-darwin: 0
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Member
|
@GrahamcOfBorg build tor-browser-bundle-bin |
Member
|
LGTM just built and run this with (sorry again for taking so long, I didn't notice this wasn't merged right away) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
tor-browser crash with certain website (like http://planet.blogsport.de/) in 20.03
original pull request: #93154
Things done
bissected the change and backported the change that fixed this
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)