python3Packages.wxpython_4_1: init at 4.1.0 by tfmoraes · Pull Request #95462 · NixOS/nixpkgs

tfmoraes · 2020-08-14T23:36:41Z

Motivation for this change

Add WXPython-4.1.0 to NixOS. The package is compiling its own wxgtk because wxpython is not compiling with it.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"

$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/thiago/.cache/nixpkgs-review/rev-7133bbdbd31696c8a646ea44e85e78f38be3ca2d/build.nix
[2 built, 0.0 MiB DL]
2 packages built:
python37Packages.wxPython_4_1 python38Packages.wxPython_4_1

$ nix-shell /home/thiago/.cache/nixpkgs-review/rev-7133bbdbd31696c8a646ea44e85e78f38be3ca2d/shell.nix

Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Ensured that relevant documentation is up to date
Fits CONTRIBUTING.md.

jonringer

looks like we already have a wxPYTHON_4_0, it would probably be best to only keep one of each major version (unless the package causes breakages between minor versions as well)

pkgs/development/python-modules/wxPython/4.1.nix

tfmoraes · 2020-08-15T02:18:46Z

looks like we already have a wxPYTHON_4_0, it would probably be best to only keep one of each major version (unless the package causes breakages between minor versions as well)

There are a lot of change between wxpython4.0.x and wxpython4.1.x. For instance wxWidgets/Phoenix#1612

pkgs/development/python-modules/wxPython/4.1.nix

tfmoraes · 2020-08-15T15:37:07Z

❯ nix-shell -p nixpkgs-review --run "nixpkgs-review rev cc8fd8e62606b751555615985b9af5dc58a79dec"                                                                    
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
$ git worktree add /home/thiago/.cache/nixpkgs-review/rev-cc8fd8e62606b751555615985b9af5dc58a79dec/nixpkgs 99d379c45c793c078af4bb5d6c85459f72b1f30b
Preparing worktree (detached HEAD 99d379c45c7)
HEAD is now at 99d379c45c7 Merge pull request #79874 from oxzi/tinycbor-v0.5.3
$ nix-env -f /home/thiago/.cache/nixpkgs-review/rev-cc8fd8e62606b751555615985b9af5dc58a79dec/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit cc8fd8e62606b751555615985b9af5dc58a79dec
Auto-merging pkgs/top-level/python-packages.nix
Automatic merge went well; stopped before committing as requested
$ nix-env -f /home/thiago/.cache/nixpkgs-review/rev-cc8fd8e62606b751555615985b9af5dc58a79dec/nixpkgs -qaP --xml --out-path --show-trace --meta
2 packages added:
python37Packages.wxPython_4_1 (init at 4.1.0) python38Packages.wxPython_4_1 (init at 4.1.0)

$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/thiago/.cache/nixpkgs-review/rev-cc8fd8e62606b751555615985b9af5dc58a79dec/build.nix
[3 built, 0.0 MiB DL]
2 packages built:
python37Packages.wxPython_4_1 python38Packages.wxPython_4_1

evils · 2020-09-24T13:12:56Z

does this package expose the wxWidgets version it built?
in kicad for example, it'd be nice to be able to use the version of wxWidgets built by this, because it seems to require those packages' versions to match.
(https://gitlab.com/kicad/code/kicad/-/issues/4431)

tfmoraes · 2020-09-24T14:33:58Z

@evils it doesn't. I have this pull request to package wx3.1.4 #95460 . In this commit wxPython starts to use wx3.1.4 wxWidgets/Phoenix@57702fa#diff-abf77184f55403d75b9d51d79162a7ca

evils · 2020-09-24T18:42:55Z

In this commit wxPython starts to use wx3.1.4 wxWidgets/Phoenix@57702fa#diff-abf77184f55403d75b9d51d79162a7ca

i'm not sure why you're mentioning that
as this is after wxPython 4.1.0
and they've since advanced the dependency to wxWidgets master again

tfmoraes · 2020-09-24T21:58:05Z

@evils I was thinking in package that git-committed version of wxpython, but it's a bad idea. But I managed to compile wxPython-4.1.0 with wxWidgets-3.1.4 in my branch here https://github.com/tfmoraes/nixpkgs/tree/wxgtk314_wxpython411 . Maybe if fix your problem.

evils · 2020-09-25T08:00:12Z

@tfmoraes your wxPython 4.1.0 with wxWidgets 3.1.4 branch solves kicad issue 4431 :D

tfmoraes · 2020-09-25T18:37:02Z

@evils @jonringer what is better?

Update wxPython and wxWidgets PR and keep 2 PR?
Create a new PR with wxPython and wxWidgets together

jonringer · 2020-09-27T01:10:24Z

I would just combine the two PRs, you can use either, just make a comment saying what you decide

evils · 2020-09-27T15:24:13Z

Since this seems to copy the previous wxPython package, have you taken into account #94108?
A lot of the previous package's dependencies were unneeded

evils · 2020-09-27T15:25:10Z

pkgs/development/python-modules/wxPython/4.1.nix

+        ("appsvc",     None)
+      ]}'
+
+    # https://github.com/wxWidgets/Phoenix/pull/1584


it's probably better to refer to wxWidgets/Phoenix#1699 as that indicates this change has been upstreamed and can probably be removed at a later point

Done, in the other PR #98951

tfmoraes · 2020-09-27T15:49:21Z

I would just combine the two PRs, you can use either, just make a comment saying what you decide

Hi @jonringer, I created a new PR with wxWidgets + wxPython #98951

tfmoraes · 2020-09-27T15:50:16Z

Since this seems to copy the previous wxPython package, have you taken into account #94108?
A lot of the previous package's dependencies were unneeded

Yes, @evils in the other PR with both changes #98951

tfmoraes requested review from FRidh and jonringer as code owners August 14, 2020 23:36

jonringer reviewed Aug 15, 2020

View reviewed changes

pkgs/development/python-modules/wxPython/4.1.nix Outdated Show resolved Hide resolved

pkgs/development/python-modules/wxPython/4.1.nix Outdated Show resolved Hide resolved

tfmoraes force-pushed the wxpython-4.1 branch from 245edfb to 8567e29 Compare August 15, 2020 02:40

jonringer reviewed Aug 15, 2020

View reviewed changes

pkgs/development/python-modules/wxPython/4.1.nix Outdated Show resolved Hide resolved

tfmoraes force-pushed the wxpython-4.1 branch from db5dca5 to cc8fd8e Compare August 15, 2020 15:24

tfmoraes requested a review from jonringer August 26, 2020 21:00

evils mentioned this pull request Sep 24, 2020

kicad: use the same wxGTK version for KiCad and for wxPython #98634

Closed

10 tasks

veprbl added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 25, 2020

tfmoraes force-pushed the wxpython-4.1 branch from f286d6f to 708068b Compare September 26, 2020 22:23

tfmoraes requested review from Mic92, adisbladis, andir, cdepillabout, matthewbauer, mmahut and nbp as code owners September 26, 2020 22:23

tfmoraes requested review from stigtsp, thoughtpolice, ttuegel and zowoq as code owners September 26, 2020 22:23

tfmoraes force-pushed the wxpython-4.1 branch from 708068b to 6c9c1a6 Compare September 26, 2020 22:25

python3Packages.wxpython_4_1: init at 4.1.0

4f826b4

tfmoraes force-pushed the wxpython-4.1 branch from 539ffce to 4f826b4 Compare September 26, 2020 22:31

zowoq removed their request for review September 26, 2020 22:32

ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 26, 2020

evils reviewed Sep 27, 2020

View reviewed changes

tfmoraes closed this Oct 1, 2020

Uh oh!

Conversation

tfmoraes commented Aug 14, 2020

Motivation for this change

Things done

Uh oh!

jonringer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tfmoraes commented Aug 15, 2020

Uh oh!

Uh oh!

tfmoraes commented Aug 15, 2020

Uh oh!

evils commented Sep 24, 2020

Uh oh!

tfmoraes commented Sep 24, 2020

Uh oh!

evils commented Sep 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tfmoraes commented Sep 24, 2020

Uh oh!

evils commented Sep 25, 2020

Uh oh!

tfmoraes commented Sep 25, 2020

Uh oh!

jonringer commented Sep 27, 2020

Uh oh!

evils commented Sep 27, 2020

Uh oh!

evils Sep 27, 2020

Choose a reason for hiding this comment

Uh oh!

tfmoraes Sep 27, 2020

Choose a reason for hiding this comment

Uh oh!

tfmoraes commented Sep 27, 2020

Uh oh!

tfmoraes commented Sep 27, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

evils commented Sep 24, 2020 •

edited

Loading