cmake: Add a patch to fix a regression since CMake 3.18#95327
Merged
primeos merged 1 commit intoNixOS:stagingfrom Aug 14, 2020
Merged
cmake: Add a patch to fix a regression since CMake 3.18#95327primeos merged 1 commit intoNixOS:stagingfrom
primeos merged 1 commit intoNixOS:stagingfrom
Conversation
This fixes all CMake builds that use target_precompile_headers() and as a result fail since CMake 3.18 with e.g.: g++: error: unrecognized command line option '-Xarch_x86_64'; did you mean '-march=x86-64'? Fix NixOS#94905. CMake references: - https://gitlab.kitware.com/cmake/cmake/-/issues/21072 - https://gitlab.kitware.com/cmake/cmake/-/merge_requests/5118
ofborg
bot
added
the
10.rebuild-darwin-stdenv
ofborg
bot
added
10.rebuild-darwin: 501+
This was referenced Aug 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes all CMake builds that use target_precompile_headers() and
as a result fail since CMake 3.18 with e.g.:
g++: error: unrecognized command line option '-Xarch_x86_64'; did you mean '-march=x86-64'?
Fix #94905.
CMake references:
cc @ttuegel @LnL7 (maintainers)
cc @orivej (found the regression)
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)