Skip to content

wrapNeovim: fix darwin build#94643

Merged
danieldk merged 1 commit intoNixOS:masterfrom
doronbehar:wrapNeovim
Aug 4, 2020
Merged

wrapNeovim: fix darwin build#94643
danieldk merged 1 commit intoNixOS:masterfrom
doronbehar:wrapNeovim

Conversation

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Aug 4, 2020

Motivation for this change

Address comment in #88110 (comment) .

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Aug 4, 2020
@doronbehar doronbehar mentioned this pull request Aug 4, 2020
Merged
10 tasks
@doronbehar
Copy link
Contributor Author

doronbehar commented Aug 4, 2020

cc @cideM

@doronbehar
Copy link
Contributor Author

doronbehar commented Aug 4, 2020

@GrahamcOfBorg build neovim

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 4, 2020
@zowoq zowoq linked an issue Aug 4, 2020 that may be closed by this pull request
neovim wrapper fails to build on macOS #94633
Closed
danieldk
danieldk approved these changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed to resolve the build error on Darwin.

@danieldk danieldk merged commit a7aae2e into NixOS:master Aug 4, 2020
@cideM
Copy link
Contributor

cideM commented Aug 4, 2020

That was lightning fast, thank you (meaning "wow")

@doronbehar doronbehar deleted the wrapNeovim branch March 2, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@danieldk danieldk danieldk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

neovim wrapper fails to build on macOS

3 participants

@doronbehar @cideM @danieldk