Skip to content

blockbook: fix build on aarch64-linux#93610

Merged
mmahut merged 1 commit intoNixOS:masterfrom
prusnak:blockbook
Jul 22, 2020
Merged

blockbook: fix build on aarch64-linux#93610
mmahut merged 1 commit intoNixOS:masterfrom
prusnak:blockbook

Conversation

@prusnak
Copy link
Member

@prusnak prusnak commented Jul 21, 2020

Motivation for this change

This PR fixes the build failure on aarch64-linux. For some reason the aarch64 build does not seem to be able to find the latest libstdc++, so we help a little with adding -L${stdenv.cc.cc.lib}/lib explicitly to the CGO_LDFLAGS.

Plus I cleaned up the package a little bit

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak prusnak requested review from 1000101 and mmahut July 21, 2020 20:23
@prusnak
Copy link
Member Author

prusnak commented Jul 21, 2020

@GrahamcOfBorg build blockbook

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jul 22, 2020
@ofborg ofborg bot requested a review from kalbasit July 22, 2020 00:41
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jul 22, 2020
1000101
1000101 approved these changes Jul 22, 2020
View reviewed changes
Copy link
Member

@1000101 1000101 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!!!

  • reviewed the diff and commit messages
  • made sure ofBorg build succeeded for all applicable platforms
  • ran nix-review without any failures
  • ran and tested the binaries (x86_64-linux only)

@mmahut mmahut merged commit b8c367a into NixOS:master Jul 22, 2020
@prusnak prusnak deleted the blockbook branch July 22, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmahut mmahut Awaiting requested review from mmahut

@kalbasit kalbasit Awaiting requested review from kalbasit

1 more reviewer

@1000101 1000101 1000101 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@prusnak @1000101 @mmahut