Skip to content

[20.03] nixos/i2pd: address #63103#88884

Merged
rnhmjoj merged 1 commit intoNixOS:release-20.03from
woffs:pr-fix-86540
May 26, 2020
Merged

[20.03] nixos/i2pd: address #63103#88884
rnhmjoj merged 1 commit intoNixOS:release-20.03from
woffs:pr-fix-86540

Conversation

@woffs
Copy link
Contributor

@woffs woffs commented May 25, 2020

As a comment to 1d61efb
Note that collect returns a list from a set

(cherry picked from commit 9bab9e2)

Motivation for this change

fix #86540

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@edwtjo @woffs
nixos/i2pd: address NixOS#63103
ef573a2 
As a comment to 1d61efb
Note that collect returns a list from a set

(cherry picked from commit 9bab9e2)
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels May 25, 2020
@rnhmjoj rnhmjoj merged commit 556b6f3 into NixOS:release-20.03 May 26, 2020
@rnhmjoj rnhmjoj mentioned this pull request May 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@woffs @rnhmjoj @edwtjo