I had thought about that as well, I don't think symlinkJoin would be the best solution since the binary gets built from makeWrapper, and share is the only other folder involved. I don't see why /share/{locale,man,nvim,pixmaps} couldn't be symlinked, and if not on darwin then symlink and subtitute the desktop file.

I'll submit another PR to add that, but since that PR will just update what gets pushed in this one, should I just close this one and submit the other to avoid a useless commit?

Sometimes, in my own overlays, I do something like this:

          octave-wrapped = super.symlinkJoin rec {
            name = "octave-wrapped";
            paths = [ super.octave ];
            pythonEnv = super.python3.withPackages(ps: [
              ps.sympy
            ]);
            nativeBuildInputs = [ super.makeWrapper ];
            # along with some fixes to the desktop file
            postBuild = ''
              cp -L $out/bin/octave $out/bin/octave.tmp
              mv -f $out/bin/octave.tmp $out/bin/octave
              wrapProgram $out/bin/octave --prefix PATH : ${pythonEnv}/bin
              cp -L $out/share/applications/org.octave.Octave.desktop $out/share/applications/org.octave.Octave.desktop.tmp
              mv -f $out/share/applications/org.octave.Octave.desktop.tmp $out/share/applications/org.octave.Octave.desktop
              substituteInPlace $out/share/applications/org.octave.Octave.desktop \
                --replace "Terminal=false" "Terminal=true" \
                --replace "octave --gui" octave
            '';
          };

Which may seem a bit hacky but I think it's not that bad. If I were the original writer of the neovim wrapper function I'd do this. I think it'll be best for you to wait a few days and see what the neovim maintainers think about this.

Right, that is much cleaner. I'll just wait and see what happens.

#87929 (comment) sounds good, no need to open another PR. Thanks for doing this, it has been on my TODO for a while and was surprised no one complained about it (I sure did xD)

@teto Sounds good to me, I might as well mention I've got another branch where I replaced mkDerivation with symlinkJoin if we want to merge that in while we're messing with neovim.

That branch looks good. Maybe this is not related to the issue at hand, but if someone wants to wrap Neovim with a configure argument, isn't the end executable gets wrapped twice?

Yeah it'll be wrapped twice, but the arguments passed to the first wrap will be propagated up to the final binary. I don't really see a clean way to only wrap once without another optionalString, I feel like that would clutter up the postBuild.

I don't really see a clean way to only wrap once without another optionalString , I feel like that would clutter up the postBuild .

I disagree that there's no clean way to do it. The problem is that the current way the wrapper function is implemented is of low quality (if you ask me). I once wrote a generic wrapper Nix function that "compiles" a string which in turn becomes a list of arguments to wrapProgram. For Neovim's wrapper function it should be fairly easy to do something similar, it's just a bit hard to dive into the functional programming concept.

Fair point, however that would be way over my head in terms of how skilled I am in Nix, I wouldn't even know where to start in making something like that.

With #88110, the man pages and everything else is now in the wrapped neovim