Skip to content

modules/filesystems/zfs: use current kernel#86835

Closed
eadwu wants to merge 1 commit intoNixOS:masterfrom
eadwu:zfs/same-kernel
Closed

modules/filesystems/zfs: use current kernel#86835
eadwu wants to merge 1 commit intoNixOS:masterfrom
eadwu:zfs/same-kernel

Conversation

@eadwu
Copy link
Member

@eadwu eadwu commented May 4, 2020

Motivation for this change

The derivation for zfs currently doesn't pull in the same kernel if boot.kernel.randstructSeed is set to a non-zero length string resulting in an extra kernel to build while also basically destroying the purpose of setting a randstructSeed, since the kernel used to build zfs would use a different seed.

Using callPackage should also work since kernel won't be evaluated until the derivation is called, in which case the kernel would've been updated (I believe), but I'm not sure how that should be done without using a let/in block (which probably should be in all-packages.nix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

[1] https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/all-packages.nix#L16933

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 4, 2020
@eadwu eadwu force-pushed the zfs/same-kernel branch from a1eb195 to 3542551 Compare May 7, 2020 23:42
@ofborg ofborg bot removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels May 7, 2020
@eadwu eadwu force-pushed the zfs/same-kernel branch from 3542551 to a1eb195 Compare May 7, 2020 23:51
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels May 8, 2020
@eadwu eadwu mentioned this pull request May 9, 2020
10 tasks
@eadwu eadwu closed this May 15, 2020
@eadwu eadwu deleted the zfs/same-kernel branch May 15, 2020 02:11
@eadwu
Copy link
Member Author

eadwu commented May 15, 2020

Hopefully superseded by #87856.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant