Skip to content

[20.03] silence warning from #63103 in encrypted-devices.nix#86567

Merged
worldofpeace merged 1 commit intoNixOS:release-20.03from
mmilata:20.03/encrypted-devices-loaof-warning
Jun 18, 2020
Merged

[20.03] silence warning from #63103 in encrypted-devices.nix#86567
worldofpeace merged 1 commit intoNixOS:release-20.03from
mmilata:20.03/encrypted-devices-loaof-warning

Conversation

@mmilata
Copy link
Member

@mmilata mmilata commented May 2, 2020

Backport of #80504.

Motivation for this change

At least one 20.03 user was confused by the warning they didn't cause.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmilata mmilata added the 8.has: port to stable This PR already has a backport to the stable release. label May 2, 2020
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 2, 2020
@worldofpeace worldofpeace merged commit 52ff653 into NixOS:release-20.03 Jun 18, 2020
@mmilata mmilata deleted the 20.03/encrypted-devices-loaof-warning branch June 18, 2020 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants