Skip to content

dnnl: rename to oneDNN to track upstream project rename#85839

Merged
markuskowa merged 1 commit intoNixOS:masterfrom
bhipple:u/dnnl-oneDNN
May 6, 2020
Merged

dnnl: rename to oneDNN to track upstream project rename#85839
markuskowa merged 1 commit intoNixOS:masterfrom
bhipple:u/dnnl-oneDNN

Conversation

@bhipple
Copy link
Contributor

@bhipple bhipple commented Apr 23, 2020

See the link in the default.nix file for details. This adds an alias for
backwards compatibility.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
dnnl: rename to oneDNN to track upstream project rename
bab9dab 
See the link in the default.nix file for details.  This adds an alias for
backwards compatibility.
@bhipple
Copy link
Contributor Author

bhipple commented Apr 23, 2020 •
edited
Loading

@GrahamcOfBorg build oneDNN dnnl

@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package labels Apr 23, 2020
@ofborg ofborg bot requested a review from alexarice April 23, 2020 02:33
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Apr 23, 2020
@bhipple
Copy link
Contributor Author

bhipple commented May 2, 2020

CC @markuskowa

@markuskowa
Copy link
Member

markuskowa commented May 3, 2020

Depending on how widely used the libraray is, you could either make an entry in pkgs/top-level/aliases.nix or add a line to the release notes.

@bhipple
Copy link
Contributor Author

bhipple commented May 6, 2020

We have an alias here, so that should be fine.

@markuskowa markuskowa merged commit e231564 into NixOS:master May 6, 2020
@bhipple bhipple mentioned this pull request May 9, 2020
Merged
10 tasks
@bhipple bhipple deleted the u/dnnl-oneDNN branch June 2, 2020 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexarice alexarice Awaiting requested review from alexarice

Assignees

No one assigned

Labels

8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bhipple @markuskowa