Skip to content

Comments

[WIP] llvm 9 update#85151

Closed
LnL7 wants to merge 15 commits intoNixOS:masterfrom
LnL7:llvm-9-update
Closed

[WIP] llvm 9 update#85151
LnL7 wants to merge 15 commits intoNixOS:masterfrom
LnL7:llvm-9-update

Conversation

@LnL7
Copy link
Member

@LnL7 LnL7 commented Apr 13, 2020

Motivation for this change

Evaluation comparing regressions with master here
https://hydra.nixos.org/eval/1579054?compare=1575607#tabs-now-fail

TODO The darwin bootstrap-tools should be rebuilt after these changes and uploaded to tarballs.nixos.org.

/cc @NixOS/darwin-maintainers @dtzWill

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This was referenced Apr 13, 2020
Closed
Closed
@ofborg ofborg bot added 6.topic: stdenv Standard environment 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 8.has: package (new) This PR adds a new package labels Apr 13, 2020
@ofborg ofborg bot requested review from andir, edolstra, lovek323, np and pSub April 13, 2020 14:37
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Apr 13, 2020
@primeos primeos mentioned this pull request Apr 13, 2020
Closed
@ofborg ofborg bot added the 8.has: clean-up This PR removes packages or removes other cruft label Apr 19, 2020
@ofborg ofborg bot requested a review from kuznero April 19, 2020 17:38
LnL7 and others added 8 commits July 18, 2020 14:45
@LnL7
darwin: update bootstrap-tools to use llvm_9
ae68f1c
@LnL7
stdenv: update darwin bootstrap tools
9989b7d 
Build from c4f9734.

https://hydra.nixos.org/build/114670681
@LnL7
llvmPackages: update default version
cf510f4
@LnL7
mpfr: disable test for clang 9
7c89e43 
Bug reported by upstream https://bugs.llvm.org/show_bug.cgi?id=43557
@LnL7
groff: fix build with clang 9
fea14da 
    make[1]: Entering directory '/private/tmp/nix-build-groff-1.22.4.drv-0/groff-1.22.4'
      CXX      src/devices/grodvi/dvi.o
      CXX      src/libs/libdriver/input.o
      CXX      src/libs/libdriver/printer.o
      AR       libdriver.a
      CXX      src/libs/libgroff/libgroff_a-assert.o
    In file included from src/libs/libgroff/assert.cpp:20:
    In file included from /nix/store/z25l6l358gcf0slg81rw8xxs3sjnghwc-libc++-9.0.0/include/c++/v1/stdlib.h:100:
    ./lib/math.h:38:3: error: "Please include config.h first."
     #error "Please include config.h first."
      ^
    ./lib/math.h:40:1: error: unknown type name '_GL_INLINE_HEADER_BEGIN'
    _GL_INLINE_HEADER_BEGIN
@LnL7
perlPackages.LocaleGettext: disable tests on darwin
d203836
@DieGoldeneEnte @LnL7
coreclr: pin to llvmPackages_7
94816b2 
coreclr needs to be compiled with clang 7, because of the internal
assembler.
I duplicated the change from 054dc14
here to prevent duplicating the commit.
@DieGoldeneEnte @LnL7
irods: pin to llvmPackages_7
b211cd4 
irods needs llvmPackages_7, because it uses boost160.
@nixos-discourse
Copy link

nixos-discourse commented Jan 5, 2021

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/why-is-darwin-llvm-so-old/10822/2

@SuperSandro2000 SuperSandro2000 added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 18, 2021
@thefloweringash thefloweringash mentioned this pull request Feb 5, 2021
Merged
21 tasks
@toonn toonn mentioned this pull request Apr 28, 2021
Merged
toonn added a commit to toonn/nixpkgs that referenced this pull request May 23, 2021
@toonn
bootstrap-tools: Include libclang-cpp.dylib
d9e2354 
Credits to @LnL7, this is based on commit
ae68f1c from PR NixOS#85151.
toonn added a commit to toonn/nixpkgs that referenced this pull request Jun 5, 2021
@toonn
bootstrap-tools: Include libclang-cpp.dylib
d259fcc 
Credits to @LnL7, this is based on commit
ae68f1c from PR NixOS#85151.
@stale
Copy link

stale bot commented Jul 21, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 21, 2021
sternenseemann pushed a commit to sternenseemann/nixpkgs that referenced this pull request Jul 24, 2021
@toonn @sternenseemann
bootstrap-tools: Include libclang-cpp.dylib
1ea8705 
Credits to @LnL7, this is based on commit
ae68f1c from PR NixOS#85151.
@toonn toonn mentioned this pull request Oct 22, 2021
Merged
@Mindavi
Copy link
Contributor

Mindavi commented Nov 27, 2021

Is this still relevant?

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 27, 2021
@Atemu
Copy link
Member

Atemu commented Mar 30, 2022

This has been superseded by #126411 and #142593

@Atemu Atemu closed this Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andir andir Awaiting requested review from andir

@lovek323 lovek323 Awaiting requested review from lovek323

@edolstra edolstra Awaiting requested review from edolstra

@pSub pSub Awaiting requested review from pSub

@np np Awaiting requested review from np

@kuznero kuznero Awaiting requested review from kuznero

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: stdenv Standard environment 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch.

Projects

No open projects
Staging
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@LnL7 @nixos-discourse @Mindavi @Atemu @SuperSandro2000 @DieGoldeneEnte