treewide: Fix types of stripDebugList attrs (and fix doc)#84551
Merged
Ma27 merged 2 commits intoNixOS:masterfrom Apr 14, 2020
Merged
treewide: Fix types of stripDebugList attrs (and fix doc)#84551Ma27 merged 2 commits intoNixOS:masterfrom
Ma27 merged 2 commits intoNixOS:masterfrom
Conversation
The documentation says this should be a list, and it already is in about half the expressions that set it. The difference doesn't matter at present, because these values are all space-free literals. But it will in a future with __structuredAttrs . (The similar attr stripAllList has no users in the nixpkgs tree, so there's nothing to do to fix any of those up.)
Ma27
approved these changes
Apr 14, 2020
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The documentation says this should be a list, and it already is in about half the expressions that set it.
The difference doesn't matter at present, because the elements of these are all space-free literals. But it will in a future with __structuredAttrs .
(The similar attr stripAllList has no users in the nixpkgs tree, so there's nothing to do to fix any of those up.)
Also fix the default value mentioned in the doc, as I noticed when grepping that it was out of date.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)