Skip to content

jetbrains.jdk: build from source#82361

Merged
FRidh merged 1 commit intomasterfrom
unknown repository
Mar 14, 2020
Merged

jetbrains.jdk: build from source#82361
FRidh merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Mar 12, 2020

Motivation for this change

Source is always better I guess, supports more architectures and we can patch things if needed.
Depends on #82349

Screenshot of WebStorm running with source-built jetbrains-jdk:

screenshot

Currently IntelliJ IDEs show this warning:
Early Access Java versions may cause compatibility issues. Use a stable release version.
This check is located here: https://github.com/JetBrains/intellij-community/blob/master/platform/platform-impl/src/com/intellij/ide/SystemHealthMonitor.java#L63

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost ghost requested a review from edwtjo as a code owner March 12, 2020 00:03
@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Mar 12, 2020
@ofborg ofborg bot requested a review from edwtjo March 12, 2020 14:13
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Mar 12, 2020
@FRidh FRidh merged commit 3a2c21d into NixOS:master Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants