Skip to content

silence warning from #63103 in encrypted-devices.nix#80504

Merged
rnhmjoj merged 1 commit intoNixOS:masterfrom
ben0x539:encrypted-devices-loa-warning
Feb 19, 2020
Merged

silence warning from #63103 in encrypted-devices.nix#80504
rnhmjoj merged 1 commit intoNixOS:masterfrom
ben0x539:encrypted-devices-loa-warning

Conversation

@ben0x539
Copy link
Contributor

@ben0x539 ben0x539 commented Feb 19, 2020

Motivation for this change

there's red text when i update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 19, 2020
rnhmjoj
rnhmjoj approved these changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you.

@rnhmjoj rnhmjoj merged commit d4c0e72 into NixOS:master Feb 19, 2020
@ben0x539 ben0x539 deleted the encrypted-devices-loa-warning branch February 21, 2020 04:24
@mmilata mmilata mentioned this pull request May 2, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ben0x539 @rnhmjoj