Skip to content

cpp-utilities: patch upstream issue #18#80014

Merged
veprbl merged 1 commit intoNixOS:masterfrom
doronbehar:improve-cpp-utilitis
Feb 25, 2020
Merged

cpp-utilities: patch upstream issue #18#80014
veprbl merged 1 commit intoNixOS:masterfrom
doronbehar:improve-cpp-utilitis

Conversation

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Feb 13, 2020 •
edited
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 13, 2020
@doronbehar doronbehar mentioned this pull request Feb 23, 2020
Closed
veprbl
veprbl reviewed Feb 24, 2020
View reviewed changes
@veprbl veprbl merged commit d7c6c9a into NixOS:master Feb 25, 2020
@veprbl
Copy link
Member

veprbl commented Feb 25, 2020

@doronbehar Thank you!

dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Feb 25, 2020
@doronbehar @dtzWill
cpp-utilities: patch upstream issue 18 (NixOS#80014)
4cafcea 
See Martchus/cpp-utilities#18

(cherry picked from commit d7c6c9a)
@doronbehar doronbehar deleted the improve-cpp-utilitis branch March 2, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@veprbl veprbl veprbl left review comments

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

syncthingtray doesn't build Prefix is doubled in cmake INTERFACE_INCLUDE_DIRECTORIES

2 participants

@doronbehar @veprbl