haskell generic-builder: Fix package conf handling#78738
Closed
infinisil wants to merge 5 commits intoNixOS:haskell-updatesfrom
Closed
haskell generic-builder: Fix package conf handling#78738infinisil wants to merge 5 commits intoNixOS:haskell-updatesfrom
infinisil wants to merge 5 commits intoNixOS:haskell-updatesfrom
Conversation
This update was generated by hackage2nix v2.15.0-14-gb942b6a from Hackage revision commercialhaskell/all-cabal-hashes@dd3690b.
https://mail.haskell.org/pipermail/ghc-devs/2020-January/018530.html The version previously fetched was `8.10.0.20200108`.
ghc: update 8.10.1 pre-release to announced rc1
This update was generated by hackage2nix v2.15.0-14-gb942b6a from Hackage revision commercialhaskell/all-cabal-hashes@31aa820.
Member
Author
|
Such that people can find this issue, here is the error message this fixes on macOS using GHC 8.8.1 (can occur during building or running): |
infinisil
force-pushed
the
haskell-updates
branch
from
33ab8a7 to
e954dc7
Compare
Ericson2314
approved these changes
Jan 29, 2020
Member
Ericson2314
left a comment
Ericson2314
left a comment
There was a problem hiding this comment.
Nice work munging around with the stuff. We should raise the issue upstream that they ought to migrate to more standardized encodings.
infinisil
force-pushed
the
haskell-updates
branch
from
e954dc7 to
8029329
Compare
Previously the package conf files were handled without paying attention
to the fact that it's pretty-printed output. One problem was discovered
with GHC 8.8.1 on Darwin, where the dynamic-library-dirs first field
seems to have increased in length, meaning while before it was
dynamic-library-dirs: some-small-directory-name
some-more-directories
Now it is
dynamic-library-dirs:
some-larger-directory-name
some-more-directories
Which breaks the code installed for NixOS#25537,
because that assumed the former format, resulting in the reoccurence of
the bug in NixOS#22810, see
infinisil/all-hies#43
This commit fixes this by "unprettyfying" the package conf files before
processing them.
infinisil
force-pushed
the
haskell-updates
branch
from
8029329 to
8be38e9
Compare
Member
Author
|
Oh and another change of behavior is how now all directories in |
Member
Author
|
With this change I just pushed I can confirm that this fixes the issue |
Member
Author
|
Anybody have any objections? Otherwise I'd like to have this merged soon |
peti
pushed a commit
that referenced
this pull request
Jan 31, 2020
Previously the package conf files were handled without paying attention
to the fact that it's pretty-printed output. One problem was discovered
with GHC 8.8.1 on Darwin, where the dynamic-library-dirs first field
seems to have increased in length, meaning while before it was
dynamic-library-dirs: some-small-directory-name
some-more-directories
Now it is
dynamic-library-dirs:
some-larger-directory-name
some-more-directories
Which breaks the code installed for #25537,
because that assumed the former format, resulting in the reoccurence of
the bug in #22810, see
infinisil/all-hies#43
This commit fixes this by "unprettyfying" the package conf files before
processing them.
Closes #78738.
Member
|
Pushed in 55a8169. Test builds are running at https://hydra.nixos.org/eval/1567978. |
4 tasks
Member
Author
|
Seems to be failing, but that very much seems unrelated: I hope that's just a transient failure, I'll restart the build |
Member
Author
|
Nevermind, I can't restart that job, "Only the project members, administrators, and accounts with restart-jobs privileges can perform this operation." |
Member
|
I have restarted the |
infinisil
added a commit
to infinisil/all-hies
that referenced
this pull request
Feb 1, 2020
This nixpkgs version includes NixOS/nixpkgs#78738
anna328p
pushed a commit
to anna328p/nixpkgs
that referenced
this pull request
Feb 2, 2020
Previously the package conf files were handled without paying attention
to the fact that it's pretty-printed output. One problem was discovered
with GHC 8.8.1 on Darwin, where the dynamic-library-dirs first field
seems to have increased in length, meaning while before it was
dynamic-library-dirs: some-small-directory-name
some-more-directories
Now it is
dynamic-library-dirs:
some-larger-directory-name
some-more-directories
Which breaks the code installed for NixOS#25537,
because that assumed the former format, resulting in the reoccurence of
the bug in NixOS#22810, see
infinisil/all-hies#43
This commit fixes this by "unprettyfying" the package conf files before
processing them.
Closes NixOS#78738.
jpgu-epam
pushed a commit
to jpgu-epam/nixpkgs
that referenced
this pull request
Feb 4, 2020
Previously the package conf files were handled without paying attention
to the fact that it's pretty-printed output. One problem was discovered
with GHC 8.8.1 on Darwin, where the dynamic-library-dirs first field
seems to have increased in length, meaning while before it was
dynamic-library-dirs: some-small-directory-name
some-more-directories
Now it is
dynamic-library-dirs:
some-larger-directory-name
some-more-directories
Which breaks the code installed for NixOS#25537,
because that assumed the former format, resulting in the reoccurence of
the bug in NixOS#22810, see
infinisil/all-hies#43
This commit fixes this by "unprettyfying" the package conf files before
processing them.
Closes NixOS#78738.
10 tasks
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Previously the package conf files were handled without paying attention to the fact that it's pretty-printed output. One problem was discovered with GHC 8.8.1 on Darwin, where the dynamic-library-dirs first field seems to have increased in length, meaning while before it was
Now it is
Which breaks the code installed for #25537 because it assumed the former format, resulting in the reoccurence of the bug in #22810, see infinisil/all-hies#43
This commit fixes this by unprettifying the package conf files before
processing them. This also gets rid of a nasty sed expression previously used to do this conf format juggling
The only change of behavior is that whereas previously above line would be changed to
it now is changed to (
some-more-directoriesisn't present anymore)But this isn't a problem because all
.dylib's in those directories will have been symlinked into$out/lib/linksanyways.Ping @peti @copumpkin @Ericson2314 @LnL7 @shlevy
Things done