Skip to content

public-inbox: fix build#77574

Merged
alyssais merged 1 commit intoNixOS:masterfrom
alyssais:public-inbox-date
Jan 14, 2020
Merged

public-inbox: fix build#77574
alyssais merged 1 commit intoNixOS:masterfrom
alyssais:public-inbox-date

Conversation

@alyssais
Copy link
Member

Motivation for this change

This fixes some two-digit year rounding bugs that started triggering
because 2020 is closer to 2070 than 1970. Apparently two digits years
are still a thing.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 12, 2020
@alyssais alyssais requested a review from teto January 13, 2020 02:02
@alyssais alyssais mentioned this pull request Jan 13, 2020
10 tasks
This fixes some two-digit year rounding bugs that started triggering
because 2020 is closer to 2070 than 1970.  Apparently two digits years
are still a thing.
@alyssais alyssais merged commit 10b1ba0 into NixOS:master Jan 14, 2020
@alyssais alyssais deleted the public-inbox-date branch January 14, 2020 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant