Skip to content

tree-wide: fix errors and warning related to loaOf deprecation#77177

Merged
worldofpeace merged 1 commit intomasterfrom
unknown repository
Jan 7, 2020
Merged

tree-wide: fix errors and warning related to loaOf deprecation#77177
worldofpeace merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Jan 7, 2020

Motivation for this change

While updating my nixpkgs I ran into various warnings and errors related to the loaOf deprecation in #63103. I fixed those here.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ghost ghost requested a review from peti as a code owner January 7, 2020 05:18
@ghost
Copy link
Author

ghost commented Jan 7, 2020 •
edited by worldofpeace
Loading

CC @rnhmjoj @worldofpeace @aanderse

worldofpeace
worldofpeace approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@worldofpeace worldofpeace merged commit 04f6b5c into NixOS:master Jan 7, 2020
@worldofpeace worldofpeace mentioned this pull request Jan 7, 2020
Closed
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Jan 7, 2020

Thank you

@bachp bachp mentioned this pull request Jan 8, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peti peti Awaiting requested review from peti

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rnhmjoj @worldofpeace