Skip to content

nixos/doc: document the loaOf type deprecation#77109

Merged
infinisil merged 1 commit intoNixOS:masterfrom
rnhmjoj:loaof-doc
Jan 8, 2020
Merged

nixos/doc: document the loaOf type deprecation#77109
infinisil merged 1 commit intoNixOS:masterfrom
rnhmjoj:loaof-doc

Conversation

@rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Jan 6, 2020

Motivation for this change

Add a release note for PR #63103.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested NixOS manual builds with nix-build nixos/release.nix -A manual.x86_64-linux
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @worldofpeace @aanderse @infinisil

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 7, 2020
@worldofpeace worldofpeace mentioned this pull request Jan 7, 2020
Closed
infinisil
infinisil requested changes Jan 7, 2020
View reviewed changes
worldofpeace
worldofpeace approved these changes Jan 8, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@worldofpeace
Copy link
Contributor

worldofpeace commented Jan 8, 2020

Here's a screenshot

Screenshot from 2020-01-07 19 05 55

infinisil
infinisil approved these changes Jan 8, 2020
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@infinisil infinisil merged commit 32104e7 into NixOS:master Jan 8, 2020
@rnhmjoj rnhmjoj deleted the loaof-doc branch January 8, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@infinisil infinisil infinisil approved these changes

+1 more reviewer

@worldofpeace worldofpeace worldofpeace approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rnhmjoj @worldofpeace @infinisil