Skip to content

Comments

pangox_compat: drop#76412

Merged
jtojnar merged 3 commits intoNixOS:masterfrom
jtojnar:pangox-compat-drop
Dec 24, 2019
Merged

pangox_compat: drop#76412
jtojnar merged 3 commits intoNixOS:masterfrom
jtojnar:pangox-compat-drop

Conversation

@jtojnar
Copy link
Member

@jtojnar jtojnar commented Dec 24, 2019

Continuation of #75909
Closes: #75790

  • For openmodelica, it was probably also just dependency of gtkglext since I cannot find any reference to pangox in the repo. But cannot verify build since it is broken.
  • Likely the same for anydesk but we cannot recompile it so we had to remove it from DT_NEEDED. Seems to start at least.

cc @worldofpeace, @shyim (anydesk maintainer), @fionera (#75943)

Likely just dependency of `gtkglext` since it is not listed in the readme.

For some reason, --remove-needed does not seem to work with the first patchelf invocation so I had to do it separately.
It was probably just a dependency of `gtkglext` since I cannot find any reference to `pangox` in the repo.

But cannot verify build since it is broken.
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nixos-rebuild-failed-pango-compat-bug/5203/2

@ofborg ofborg bot added the 8.has: clean-up This PR removes packages or removes other cruft label Dec 24, 2019
@ofborg ofborg bot requested review from sergei-mironov and shyim December 24, 2019 15:33
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 24, 2019
Copy link
Member

@shyim shyim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested looks good for me

@jtojnar jtojnar merged commit b1b26f8 into NixOS:master Dec 24, 2019
@jtojnar jtojnar deleted the pangox-compat-drop branch December 24, 2019 19:04
@nixos-discourse

This comment has been minimized.

@worldofpeace
Copy link
Contributor

I think we're missing a throw in aliases.nix here.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nixos-rebuild-failed-pango-compat-bug/5203/7

dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 23, 2020
pangox_compat: drop

(cherry picked from commit b1b26f8)
balodja added a commit to balodja/nixpkgs that referenced this pull request Apr 24, 2021
balodja added a commit to balodja/nixpkgs that referenced this pull request May 12, 2021
balodja added a commit to balodja/nixpkgs that referenced this pull request Jul 23, 2021
Most of them are:
* separate packages for different openmodelica components,
* qt4 -> qt5,
* patches to instruct the OMEdit wrapper with stdenv executables
  location,
* adoption of NixOS#89731 and NixOS#109595,
* openblas -> blas, lapack according to NixOS#83888,
* parallel building,
* getting rid of spurious build phases,
* correct the license,
* cross-compilation,
* forcing compiler to clang++ according to OM build recommendations,
* drop of pangox_compat according to NixOS#75909 and NixOS#76412,
* better dependencies, and more.
balodja added a commit to balodja/nixpkgs that referenced this pull request Jul 24, 2021
Co-authored-by: Jaakko Luttinen <[email protected]>

Most of changes are:
* separate packages for different openmodelica components,
* qt4 -> qt5,
* patches to instruct the OMEdit wrapper with stdenv executables
  location,
* adoption of NixOS#89731 and NixOS#109595,
* openblas -> blas, lapack according to NixOS#83888,
* parallel building,
* getting rid of spurious build phases,
* correct the license,
* cross-compilation,
* forcing compiler to clang++ according to OM build recommendations,
* drop of pangox_compat according to NixOS#75909 and NixOS#76412,
* better dependencies, and more.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

Development

Successfully merging this pull request may close these issues.

Newer version of pango seems to have broken a few packages

4 participants