Skip to content

rustc: 1.39 -> 1.40#76100

Closed
edolstra wants to merge 1 commit intoNixOS:masterfrom
edolstra:rust-1.40
Closed

rustc: 1.39 -> 1.40#76100
edolstra wants to merge 1 commit intoNixOS:masterfrom
edolstra:rust-1.40

Conversation

@edolstra
Copy link
Member

@edolstra edolstra commented Dec 20, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@edolstra edolstra added the 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. label Dec 20, 2019
@edolstra edolstra requested review from LnL7 and Mic92 as code owners December 20, 2019 13:11
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Dec 20, 2019
@Mic92
Copy link
Member

Mic92 commented Dec 20, 2019

Merge conflict due to documentation update.

@Mic92
Copy link
Member

Mic92 commented Dec 24, 2019

I am about to build fd on aarch64-linux and x86_64-linux.
We also need a macOS build. @alyssais @grahamc or @LnL7 could either of you run:

$ nix-review pr -p fd 76100

Our firefox/thunderbird build is still based on the old rustc version.

@Mic92
Copy link
Member

Mic92 commented Dec 24, 2019

fd on aarch64 builds!

LnL7
LnL7 approved these changes Dec 24, 2019
View reviewed changes
Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Darwin build also looks good.

@Mic92
Copy link
Member

Mic92 commented Dec 24, 2019

fd on x86_64 builds!

@Mic92
Copy link
Member

Mic92 commented Dec 24, 2019 •
edited
Loading

pushed to staging: e82fae1

@Mic92 Mic92 closed this Dec 24, 2019
@oxalica oxalica mentioned this pull request Jan 2, 2020
Closed
10 tasks
@edolstra edolstra deleted the rust-1.40 branch January 3, 2020 14:12
@nmattia
Copy link
Contributor

nmattia commented Jan 24, 2020

@edolstra @Mic92 why delete 1.39? I thought we started tracking multiple versions: #73039

@nmattia
Copy link
Contributor

nmattia commented Jan 24, 2020

or rather, why keep 1.38?

@edolstra
Copy link
Member Author

edolstra commented Jan 24, 2020

We only keep old versions if there a specific need. 1.38 is (was?) needed for Firefox.

@tjni tjni mentioned this pull request Nov 12, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mic92 Mic92 Mic92 approved these changes

+1 more reviewer

@LnL7 LnL7 LnL7 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@edolstra @Mic92 @nmattia @LnL7