Skip to content

Add some documentation for texlive#74519

Merged
veprbl merged 6 commits intoNixOS:masterfrom
immae:patch-1
Dec 21, 2019
Merged

Add some documentation for texlive#74519
veprbl merged 6 commits intoNixOS:masterfrom
immae:patch-1

Conversation

@immae
Copy link
Contributor

@immae immae commented Nov 28, 2019

Motivation for this change

Provides documentation for adding custom packages to texlive.combine

Fixes: #17748

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @vcunat @veprbl @lovek323 @jwiegley @raskin

There seem to be no good way of adding a custom package to texlive.combine, this change proposes a hackish way of doing it
@immae
Copy link
Contributor Author

immae commented Nov 28, 2019

At maintainers:
This PR is also a way open a discussion about this issue, maybe I missed the "good" way of doing what I want. In any case it seem to lack documentation about how to do (good or hackish)

@tilpner
Copy link
Member

tilpner commented Nov 28, 2019

(I think @immae meant to cc @7c6f434c instead of @raskin)

@ofborg ofborg bot added 6.topic: TeX Issues regarding texlive and TeX in general 8.has: documentation This PR adds or changes documentation labels Nov 28, 2019
@immae
Copy link
Contributor Author

immae commented Nov 28, 2019

Oups sorry, I thought there were a correspondance between the name in the meta.maintainers and the github id

@immae
Copy link
Contributor Author

immae commented Nov 28, 2019

2019-11-28_19_50_55

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 28, 2019
@veprbl
Copy link
Member

veprbl commented Nov 30, 2019

Related to #17748

@veprbl
Copy link
Member

veprbl commented Dec 21, 2019

I've updated the PR. Wording was adjusted to be more neutral. By that I mean that we don't need to provide reader with our opinion on the interface texlive.combine, those are not that informative, and, I believe, we can safely assume that our users are perfectly capable of making their own mind about things. I also provide an example of using a specific package. I chose it mostly because it's the only external package that I am familiar with.

@immae
Copy link
Contributor Author

immae commented Dec 21, 2019

Again, I don’t see how I expressed any opinion about the interface, but English is not my mother language so maybe I miss some subtelties. Thanks for the update!

@veprbl veprbl merged commit b42bede into NixOS:master Dec 21, 2019
@veprbl
Copy link
Member

veprbl commented Dec 21, 2019

@immae Thank you for addressing this!

@Janik-Haag Janik-Haag added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: TeX Issues regarding texlive and TeX in general 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

texlive.combine: use your own packages

4 participants