Skip to content

lmms: fix qt5#73558

Merged
Lassulus merged 4 commits intoNixOS:masterfrom
nek0:fix_qt5_lmms
Nov 24, 2019
Merged

lmms: fix qt5#73558
Lassulus merged 4 commits intoNixOS:masterfrom
nek0:fix_qt5_lmms

Conversation

@nek0
Copy link
Contributor

@nek0 nek0 commented Nov 17, 2019

Motivation for this change

LMMS did not start, throwing a well known qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in "" error.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @cillianderoiste @yegortimoshenko

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 17, 2019
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Nov 17, 2019

Can you add another commit to disable the build on aarch64? ofBorg shows it's failing.

@ofborg ofborg bot added the 8.has: clean-up This PR removes packages or removes other cruft label Nov 20, 2019
@nek0
Copy link
Contributor Author

nek0 commented Nov 21, 2019

done

Lassulus
Lassulus approved these changes Nov 24, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review, works as expected

@Lassulus Lassulus merged commit cd07c6d into NixOS:master Nov 24, 2019
This was referenced Nov 8, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lassulus Lassulus Lassulus approved these changes

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

@lukateras lukateras Awaiting requested review from lukateras

Assignees

No one assigned

Labels

8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nek0 @rnhmjoj @Lassulus