buildStackProject: Set __noChroot to make it fail without sandbox#73362
Merged
cdepillabout merged 2 commits intoNixOS:masterfrom Nov 14, 2019
Merged
buildStackProject: Set __noChroot to make it fail without sandbox#73362cdepillabout merged 2 commits intoNixOS:masterfrom
cdepillabout merged 2 commits intoNixOS:masterfrom
Conversation
ofborg
bot
added
6.topic: haskell
Member
|
@infinisil Thanks for this change. I was actually thinking of doing this myself. I think this is okay as-is, if you'd like to go ahead and merge it. However, if possible, I think it would be nice to add a little more documentation. For example, either linking to the nix manual where it talks about As a new user, at one point I came across |
Building such a derivation will result in error: derivation '/nix/store/nk4wms3hk4mp9lc86k30vc8w44fcq0rj-foo.drv' has '__noChroot' set, but that's not allowed when 'sandbox' is 'true' when attempting to build it without --option sandbox false
infinisil
force-pushed
the
buildStackProjectChroot
branch
from
49b2922 to
27e7b9a
Compare
Member
Author
|
Added a bit more comment and docs |
Member
|
Thanks! Looks really good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Currently
buildStackProjectdoesn't have any indication that it needs the sandbox to be disabled, leading to a hard-to-decipher error, see #32005With this change, doing a
buildStackProjectwill result inwhen attempting to build it without
--option sandbox falseFixes #32005
Things done