Skip to content

audacity: use gtk version passed through wxwidgets#73055

Merged
c0bw3b merged 1 commit intoNixOS:masterfrom
wakira:audacity
Nov 13, 2019
Merged

audacity: use gtk version passed through wxwidgets#73055
c0bw3b merged 1 commit intoNixOS:masterfrom
wakira:audacity

Conversation

@wakira
Copy link
Member

@wakira wakira commented Nov 8, 2019

Make possible to build against gtk3, which is useful for HiDPI displays.

Motivation for this change

audacity looks pretty bad with HiDPI scaling on gtk2. This change removes hard dependency on gtk2, which should prevent build failure when wxWidgets is overridden to build against gtk3.

* The option to use gtk3 is not very obvious. Maybe we should use an alternative approach, such as a withGtk3 option that overrides the gtk version in wxWidgets?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @the-kenny

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 8, 2019
@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 12, 2019

Hello and welcome around here @wakira ; thanks for your first contribution to nixpkgs :)

Related work in #73145
but that doesn't block this PR.

Make possible to build against gtk3, which is useful for HiDPI displays.
@c0bw3b c0bw3b merged commit 967d294 into NixOS:master Nov 13, 2019
@c0bw3b c0bw3b mentioned this pull request Nov 13, 2019
10 tasks
@Janik-Haag Janik-Haag added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants