audacity: use gtk version passed through wxwidgets#73055
Merged
c0bw3b merged 1 commit intoNixOS:masterfrom Nov 13, 2019
Merged
Conversation
c0bw3b
reviewed
Nov 12, 2019
Contributor
Make possible to build against gtk3, which is useful for HiDPI displays.
c0bw3b
approved these changes
Nov 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make possible to build against gtk3, which is useful for HiDPI displays.
Motivation for this change
audacity looks pretty bad with HiDPI scaling on gtk2. This change removes hard dependency on gtk2, which should prevent build failure when wxWidgets is overridden to build against gtk3.
* The option to use gtk3 is not very obvious. Maybe we should use an alternative approach, such as a
withGtk3option that overrides the gtk version in wxWidgets?Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @the-kenny