Skip to content

rust: keep multiple version#73039

Merged
edolstra merged 1 commit intoNixOS:masterfrom
taku0:rust_multiple_version
Nov 8, 2019
Merged

rust: keep multiple version#73039
edolstra merged 1 commit intoNixOS:masterfrom
taku0:rust_multiple_version

Conversation

@taku0
Copy link
Contributor

@taku0 taku0 commented Nov 8, 2019

Motivation for this change

Firefox 70.0.1 and Thunderbird 68.2.2 require older version of rustc.
#72006
#73023

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @madjar, @cstrahan, @globin, @Havvy, @edolstra

@taku0
rust: keep multiple version.
97f20c3 
Firefox 70.0.1 and Thunderbird 68.2.2 require older version of rustc.
@taku0 taku0 requested review from LnL7 and Mic92 as code owners November 8, 2019 12:16
This was referenced Nov 8, 2019
Merged
Closed
@ofborg ofborg bot added 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 8, 2019
@d-goldin
Copy link
Contributor

d-goldin commented Nov 8, 2019 •
edited
Loading

Gave a nix-review run and briefly tested thunderbird on nixos. Worked out fine.

@edolstra edolstra merged commit e4a6fba into NixOS:master Nov 8, 2019
@taku0 taku0 mentioned this pull request Nov 8, 2019
Merged
10 tasks
@nmattia nmattia mentioned this pull request Jan 24, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LnL7 LnL7 Awaiting requested review from LnL7

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees

No one assigned

Labels

6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@taku0 @d-goldin @edolstra