Skip to content

Revert "lvm2: enable parallel building"#72823

Merged
FRidh merged 2 commits intoNixOS:masterfrom
kirelagin:lvm-disable-parallel
Nov 5, 2019
Merged

Revert "lvm2: enable parallel building"#72823
FRidh merged 2 commits intoNixOS:masterfrom
kirelagin:lvm-disable-parallel

Conversation

@kirelagin
Copy link
Member

Partially revert #62660 because I am still getting the error. cc @joachifm @7c6f434c

This reverts commit 494d2de.

I am getting

```
gcc: error: ../../device_mapper/libdevice-mapper.a: No such file or directory
```
@kirelagin
Copy link
Member Author

heads up @dtzWill

@ofborg ofborg bot requested a review from 7c6f434c November 5, 2019 09:35
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Nov 5, 2019
@FRidh
Copy link
Member

FRidh commented Nov 5, 2019

Please include the following link as a comment next to the code
#52597

@FRidh FRidh merged commit 2e8ed0f into NixOS:master Nov 5, 2019
@dtzWill
Copy link
Member

dtzWill commented Nov 5, 2019

@kirelagin (thanks! Appreciated!)

@kirelagin kirelagin deleted the lvm-disable-parallel branch November 5, 2019 11:05
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Nov 5, 2019
* Revert "lvm2: enable parallel building"

This reverts commit 494d2de.

I am getting

```
gcc: error: ../../device_mapper/libdevice-mapper.a: No such file or directory
```

(cherry picked from commit 2e8ed0f)
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Nov 6, 2019
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Nov 6, 2019
This reverts commit 35c57db.

The parallel build failure isn't triggered by building
the normal top-level lvm2 attribute, but some other use
that overrides some arguments and such.

Revisit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants