Skip to content

gjs: various improvements#72805

Merged
jtojnar merged 3 commits intoNixOS:masterfrom
jtojnar:gjs-improvement
Nov 5, 2019
Merged

gjs: various improvements#72805
jtojnar merged 3 commits intoNixOS:masterfrom
jtojnar:gjs-improvement

Conversation

@jtojnar
Copy link
Member

@jtojnar jtojnar commented Nov 5, 2019

  • Move to top-level
  • Clean up the expression
  • Try to build on Darwin

@jtojnar jtojnar mentioned this pull request Nov 5, 2019
@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: package (new) This PR adds a new package labels Nov 5, 2019
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Nov 5, 2019
@worldofpeace
Copy link
Contributor

worldofpeace commented Nov 5, 2019

Fails to evaluate on darwin because spidermonkey_60 doesn't.

@ofborg ofborg bot requested a review from abbradar November 5, 2019 08:48
@jtojnar
Copy link
Member Author

jtojnar commented Nov 5, 2019

Bah, it wants to execute xcode-select --print-path. Let’s just not build GIMP with JavaScript support on Darwin.

@jtojnar jtojnar merged commit 9d36ef7 into NixOS:master Nov 5, 2019
@jtojnar jtojnar deleted the gjs-improvement branch November 5, 2019 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants