nodePackages.coc-prettier: init at 1.1.10#72501
Closed
ersinakinci wants to merge 1 commit intoNixOS:masterfrom
Closed
nodePackages.coc-prettier: init at 1.1.10#72501ersinakinci wants to merge 1 commit intoNixOS:masterfrom
ersinakinci wants to merge 1 commit intoNixOS:masterfrom
Conversation
Needed by vimPlugins.coc-prettier
10 tasks
Contributor
Author
|
Closed in favor of #72506. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Needed by
vimPlugins.coc-prettier(see discussion here and here).Fuller context
Coc is a plugin that integrates Intellisense and other async language engines with Neovim/Vim 8 to provide type checking, formatting and other similar capabilities for Vim.
Coc has a modular structure and depends on installing extensions for different languages. Normally, these are installed using
:CocInstallwithin Vim, but there has been an effort to Nix-ify the process by moving the extensions into Nixpkgs:vimPlugins.coc-go,vimPlugins.coc-prettier, etc.(Many? All?) Coc extensions are essentially NPM packages. Many of the ones that are currently in
vimPluginsare broken because they exposing raw source code rather than a properly built NPM package (i.e., one that's hadnpm run buildexecuted). Hence, we need to do two things to fix them:nodePackages, thenvimPluginsusingbuildVimPluginFrom2Nixwith the package output as the source.This PR addresses the first step for one extension,This PR has been closed in favor of #72506, which combines steps 1 and 2 above.coc-prettier. A subsequent PR will fix the plugin on the Vim side using an override.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @adisbladis @rvolosatovs