Skip to content

nodePackages.coc-prettier: init at 1.1.10#72501

Closed
ersinakinci wants to merge 1 commit intoNixOS:masterfrom
ersinakinci:ersin/node-coc-prettier
Closed

nodePackages.coc-prettier: init at 1.1.10#72501
ersinakinci wants to merge 1 commit intoNixOS:masterfrom
ersinakinci:ersin/node-coc-prettier

Conversation

@ersinakinci
Copy link
Contributor

@ersinakinci ersinakinci commented Nov 2, 2019

Motivation for this change

Needed by vimPlugins.coc-prettier (see discussion here and here).

Fuller context

Coc is a plugin that integrates Intellisense and other async language engines with Neovim/Vim 8 to provide type checking, formatting and other similar capabilities for Vim.

Coc has a modular structure and depends on installing extensions for different languages. Normally, these are installed using :CocInstall within Vim, but there has been an effort to Nix-ify the process by moving the extensions into Nixpkgs: vimPlugins.coc-go, vimPlugins.coc-prettier, etc.

(Many? All?) Coc extensions are essentially NPM packages. Many of the ones that are currently in vimPlugins are broken because they exposing raw source code rather than a properly built NPM package (i.e., one that's had npm run build executed). Hence, we need to do two things to fix them:

  1. Add the underlying NPM packages to nodePackages, then
  2. Re-export the resulting package within vimPlugins using buildVimPluginFrom2Nix with the package output as the source.

This PR addresses the first step for one extension, coc-prettier. A subsequent PR will fix the plugin on the Vim side using an override. This PR has been closed in favor of #72506, which combines steps 1 and 2 above.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @adisbladis @rvolosatovs

Needed by vimPlugins.coc-prettier
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 2, 2019
@ersinakinci
Copy link
Contributor Author

Closed in favor of #72506.

@ersinakinci ersinakinci closed this Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant