pythonPackages.qscintilla-qt5: fix build#72302
Closed
das-g wants to merge 1 commit intoNixOS:release-19.09from
Closed
pythonPackages.qscintilla-qt5: fix build#72302das-g wants to merge 1 commit intoNixOS:release-19.09from
das-g wants to merge 1 commit intoNixOS:release-19.09from
Conversation
(cherry picked from commit 9209dcf)
Member
|
Hi, I have what is necessary for qgis in #72249 waiting for approval. I thing this PR might duplicate it. |
Member
Author
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 9209dcf)
Motivation for this change
Backport #71641 to make QGIS (and other applications depending on
pythonPackages.qscintilla-qt5, if any) available on NixOS 19.09. See also #71646 (comment)Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip -b release-19.09"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @lsix
results of running executable files in
./results/*/bin/produced bynix-review ...:looking fine:
(at least as far as I can tell)
qscintilla-qt5 executables (click to expand)
not working out of the box:
... and the same for qgis-unwrapped (click to expand)